pyproject: partially enable flake8-boolean-trap

Author: jelly

devel/forms.py

@@ -79,7 +79,7 @@ def clean_username(self):
         return username
 
     def save(self, commit=True):
-        profile = super(NewUserForm, self).save(False)
+        profile = super(NewUserForm, self).save(commit=False)
         pwletters = ascii_letters + digits
         password = ''.join([random.choice(pwletters) for _ in range(8)])
         user = User.objects.create_user(

devel/management/commands/reporead.py

@@ -403,7 +403,7 @@ def db_update(archname, reponame, pkgs, force=False, repo_dir=None):
     Parses a list of packages and updates the packages database accordingly.
     """
     logger.info('Updating %s (%s)', reponame, archname)
-    dbpkgs = update_common(archname, reponame, pkgs, True)
+    dbpkgs = update_common(archname, reponame, pkgs, sanity_check=True)
     repository = Repo.objects.get(name__iexact=reponame)
     architecture = Arch.objects.get(name=archname)
 
@@ -498,7 +498,7 @@ def filesonly_update(archname, reponame, pkgs, force=False):
     Parses a list of packages and updates the packages database accordingly.
     """
     logger.info('Updating files for %s (%s)', reponame, archname)
-    dbpkgs = update_common(archname, reponame, pkgs, False)
+    dbpkgs = update_common(archname, reponame, pkgs, sanity_check=False)
     dbdict = {dbpkg.pkgname: dbpkg for dbpkg in dbpkgs}
     dbset = set(dbdict.keys())
 

packages/models.py

@@ -109,7 +109,7 @@ def __str__(self):
 
 
 def fake_signoff_spec(arch):
-    return FakeSignoffSpecification(arch.required_signoffs, True, False, '')
+    return FakeSignoffSpecification(required=arch.required_signoffs, enabled=True, known_bad=False, comments='')
 
 
 class SignoffManager(models.Manager):

packages/templatetags/package_extras.py

@@ -20,7 +20,7 @@ def render(self, context):
                 qs['sort'] = ['-' + self.sortfield]
         else:
             qs['sort'] = [self.sortfield]
-        return urlencode(qs, True).replace('&', '&')
+        return urlencode(qs, doseq=True).replace('&', '&')
 
 
 @register.tag(name='buildsortqs')

packages/tests/test_adopt.py

@@ -19,7 +19,7 @@ def test_adopt_package(developer_client, package):
     assert response.status_code == 200
     assert len(PackageRelation.objects.all()) == 1
 
-    response = request(developer_client, pkg.id, False)
+    response = request(developer_client, pkg.id, adopt=False)
     assert response.status_code == 200
     assert len(PackageRelation.objects.all()) == 0
 

packages/views/signoff.py

@@ -44,7 +44,7 @@ def signoff_package(request, name, repo, arch, revoke=False):
 
     if revoke:
         try:
-            signoff = Signoff.objects.get_from_package(package, request.user, False)
+            signoff = Signoff.objects.get_from_package(package, request.user, revoked=False)
         except Signoff.DoesNotExist:
             raise Http404 from None
         signoff.revoked = now()

pyproject.toml

@@ -56,6 +56,7 @@ select = [
     "DJ",      # flake8-django
     "E",       # pycodestyle
     "F",       # pyflakes
+    "FBT",     # flake8-boolean-trap
     "G",       # flake8-logging-format
     "I",       # isort
     "ICN",     # flake8-import-conventions
@@ -78,6 +79,7 @@ ignore = [
     "DJ001", # Avoid using `null=True` on string-based fields such as `CharField`
     "DJ006", # Do not use `exclude` with `ModelForm`, use `fields` instead
     "DJ012", # Order of model's inner classes, methods, and fields does not follow the Django Style Guide: `Meta` class should come before `get_absolute_url`
+    "FBT002", # default-value-positional-argument
 ]
 
 [tool.pytest.ini_options]