devel: port to pytest

Author: jelly

devel/tests/test_pgp_import.py

@@ -1,8 +1,9 @@
 from unittest.mock import patch
 
+import pytest
+
 from django.core.management import call_command
 from django.core.management.base import CommandError
-from django.test import TransactionTestCase
 
 
 CREATED = 1541685162
@@ -19,28 +20,26 @@
 ]
 
 
-class PGPImportTest(TransactionTestCase):
-    fixtures = ['main/fixtures/arches.json', 'main/fixtures/repos.json']
-
-    def test_pgp_import_error(self):
-        with self.assertRaises(CommandError) as e:
-            call_command('pgp_import')
-        self.assertIn('keyring_path', str(e.exception))
-
-    @patch('devel.management.commands.pgp_import.call_gpg')
-    def test_pgp_import_garbage_data(self, mock_call_gpg):
-        mock_call_gpg.return_value = 'barf'
-        with patch('devel.management.commands.pgp_import.logger') as logger:
-            call_command('pgp_import', '/tmp')
-        logger.info.assert_called()
-        logger.info.assert_any_call('created %d, updated %d signatures', 0, 0)
-        logger.info.assert_any_call('created %d, updated %d keys', 0, 0)
-
-    @patch('devel.management.commands.pgp_import.call_gpg')
-    def test_pgp_import(self, mock_call_gpg):
-        mock_call_gpg.return_value = '\n'.join(SIG_DATA)
-        with patch('devel.management.commands.pgp_import.logger') as logger:
-            call_command('pgp_import', '/tmp')
-        logger.info.assert_called()
-        logger.info.assert_any_call('created %d, updated %d signatures', 0, 0)
-        logger.info.assert_any_call('created %d, updated %d keys', 1, 0)
+def test_pgp_import_error(arches, repos):
+    with pytest.raises(CommandError) as e:
+        call_command('pgp_import')
+    assert 'keyring_path' in str(e.value)
+
+
+@patch('devel.management.commands.pgp_import.call_gpg')
+def test_pgp_import_garbage_data(mock_call_gpg, arches, repos):
+    mock_call_gpg.return_value = 'barf'
+    with patch('devel.management.commands.pgp_import.logger') as logger:
+        call_command('pgp_import', '/tmp')
+    logger.info.assert_called()
+    logger.info.assert_any_call('created %d, updated %d signatures', 0, 0)
+    logger.info.assert_any_call('created %d, updated %d keys', 0, 0)
+
+@patch('devel.management.commands.pgp_import.call_gpg')
+def test_pgp_import(mock_call_gpg, arches, repos):
+    mock_call_gpg.return_value = '\n'.join(SIG_DATA)
+    with patch('devel.management.commands.pgp_import.logger') as logger:
+        call_command('pgp_import', '/tmp')
+    logger.info.assert_called()
+    logger.info.assert_any_call('created %d, updated %d signatures', 0, 0)
+    logger.info.assert_any_call('created %d, updated %d keys', 1, 0)

devel/tests/test_rematch_developers.py

@@ -1,14 +1,9 @@
 from unittest.mock import patch
 
-
 from django.core.management import call_command
-from django.test import TransactionTestCase
-
 
-class RematchDeveloperTest(TransactionTestCase):
-    fixtures = ['main/fixtures/arches.json', 'main/fixtures/repos.json']
 
-    def test_rematch_developers(self):
-        with patch('devel.management.commands.rematch_developers.logger') as logger:
-            call_command('rematch_developers')
-        logger.info.assert_called()
+def test_rematch_developers(arches, repos):
+    with patch('devel.management.commands.rematch_developers.logger') as logger:
+        call_command('rematch_developers')
+    logger.info.assert_called()

devel/tests/test_templatetags.py

@@ -1,11 +1,5 @@
-from django.contrib.auth.models import User
-from django.test import TestCase
-
 from devel.templatetags.group import in_group
 
 
-class DevelTemplatetagsTest(TestCase):
-    def test_in_group(self):
-        user = User.objects.create(username="joeuser", first_name="Joe",
-                                   last_name="User", email="[email protected]")
-        self.assertEqual(in_group(user, 'none'), False)
+def test_in_group(admin_user):
+    assert in_group(admin_user, 'none') == False