Skip to content

Commit 21353e8

Browse files
committed
fix: remove observer check from hook
1 parent f0997cc commit 21353e8

File tree

2 files changed

+0
-37
lines changed

2 files changed

+0
-37
lines changed

src/useObserver.js

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,6 @@ import createObserverPublisher from './helpers/createObserverPublisher'
66
let publishers
77

88
export default function useObserver(Observer, { observerOptions, subscribeOptions } = {}) {
9-
if (process.env.NODE_ENV !== 'production') {
10-
if (!Observer) {
11-
// eslint-disable-next-line no-console
12-
console.error(
13-
'useObserver requires a valid WebAPI Observer as a first parameter',
14-
)
15-
}
16-
}
17-
189
const [entry, setEntry] = useState({})
1910
const [element, setElement] = useState()
2011

src/useObserver.test.js

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -23,34 +23,6 @@ beforeEach(() => {
2323
})
2424
})
2525

26-
it('should throw an error if no Observer given', () => {
27-
jest.spyOn(console, 'error').mockImplementation(() => { })
28-
29-
renderHook(() => useObserver())
30-
31-
// eslint-disable-next-line no-console
32-
expect(console.error).toBeCalledWith('useObserver requires a valid WebAPI Observer as a first parameter')
33-
34-
// eslint-disable-next-line no-console
35-
console.error.mockRestore()
36-
})
37-
38-
it('should not throw an error on production mode', () => {
39-
jest.spyOn(console, 'error').mockImplementation(() => {})
40-
const env = process.env.NODE_ENV
41-
process.env.NODE_ENV = 'production'
42-
43-
const { result } = renderHook(() => useObserver())
44-
expect(result.error).toBeUndefined()
45-
46-
// eslint-disable-next-line no-console
47-
expect(console.error).not.toBeCalled()
48-
// eslint-disable-next-line no-console
49-
console.error.mockRestore()
50-
51-
process.env.NODE_ENV = env
52-
})
53-
5426
it('should create only one observer instance for same Observer and Options for all uses and rerenders', () => {
5527
const loopArr = [...Array(10)]
5628

0 commit comments

Comments
 (0)