fix mocks

resolvers that return 'subresolvers' or fields that are set to functions for later use as resolvers were behaving not according to upstream graphql-js convention, these functions take 3 arguments, not 4, with parent available as this.

See #1807
See https://github.com/graphql/graphql-js/blob/7e79bbe5f2b0e971b5e5f6fe3e7b19c43dea9f35/src/execution/execute.js#L1210-L1212

Author: yaacovCR

.changeset/weak-peaches-count.md

@@ -39,6 +39,10 @@
 
 - Support for fragment hints has been removed in favor of selection set hints.
 
+#### Mocking (`addMocksToSchema` and `@graphql-tools/mock`)
+
+- Mocks returning objects with fields set as functions are now operating according to upstream graphql-js convention, i.e. these functions take three arguments, `args`, `context`, and `info` with `parent` available as `this` rather than as the first argument.
+
 #### Other Utilities (`@graphql-tools/utils`)
 
 - `filterSchema`'s `fieldFilter` will now filter *all* fields across Object, Interface, and Input types. For the previous Object-only behavior, switch to the `objectFieldFilter` option.
@@ -53,3 +57,4 @@
 - better error handling for merges #2016, #2062
 - fix typings #1614
 - disable implicit schema pruning #1817
+- mocks not working for functions #1807

packages/mock/src/mocking.ts

@@ -124,7 +124,7 @@ export function addMocksToSchema({ schema, mocks = {}, preserveResolvers = false
 
         // if we're here, the field is already defined
         if (typeof root[fieldName] === 'function') {
-          result = root[fieldName](root, args, context, info);
+          result = root[fieldName](args, context, info);
           if (isMockList(result)) {
             result = result.mock(root, args, context, info, fieldType as GraphQLList<any>, mockType);
           }

packages/mock/tests/mocking.spec.ts

@@ -1056,7 +1056,7 @@ describe('Mock', () => {
     let jsSchema = buildSchemaFromTypeDefinitions(shorthand);
     const mockMap = {
       RootQuery: () => ({
-        returnStringArgument: (_o: any, a: Record<string, any>) => a.s,
+        returnStringArgument: (a: Record<string, any>) => a.s,
       }),
     };
     jsSchema = addMocksToSchema({ schema: jsSchema, mocks: mockMap });
@@ -1075,7 +1075,7 @@ describe('Mock', () => {
     let jsSchema = buildSchemaFromTypeDefinitions(shorthand);
     const mockMap = {
       RootMutation: () => ({
-        returnStringArgument: (_o: any, a: Record<string, any>) => a.s,
+        returnStringArgument: (a: Record<string, any>) => a.s,
       }),
     };
     jsSchema = addMocksToSchema({ schema: jsSchema, mocks: mockMap });
@@ -1129,7 +1129,7 @@ describe('Mock', () => {
     let jsSchema = buildSchemaFromTypeDefinitions(shorthand);
     const mockMap = {
       RootQuery: () => ({
-        returnListOfIntArg: (_o: any, a: Record<string, any>) =>
+        returnListOfIntArg: (a: Record<string, any>) =>
           new MockList(a.l),
       }),
       Int: () => 12,
@@ -1258,13 +1258,13 @@ describe('Mock', () => {
     // unintuitive corner-cases
     const mockMap = {
       RootQuery: () => ({
-        thread: (_o: any, a: Record<string, any>) => ({ id: a.id }),
-        threads: (_o: any, a: Record<string, any>) =>
+        thread: (a: Record<string, any>) => ({ id: a.id }),
+        threads: (a: Record<string, any>) =>
           new MockList(ITEMS_PER_PAGE * a.num),
       }),
       Thread: () => ({
         name: 'Lorem Ipsum',
-        posts: (_o: any, a: Record<string, any>) =>
+        posts: (a: Record<string, any>) =>
           new MockList(
             ITEMS_PER_PAGE * a.num,
             (_oi: any, ai: Record<string, any>) => ({

website/docs/migration-from-tools.md

@@ -37,6 +37,10 @@ If you are using GraphQL Tools v6, there are several breaking changes to be awar
 
 - Support for fragment hints has been removed in favor of selection set hints.
 
+#### Mocking (`addMocksToSchema` and `@graphql-tools/mock`)
+
+- Mocks returning objects with fields set as functions are now operating according to upstream graphql-js convention, i.e. these functions take three arguments, `args`, `context`, and `info` with `parent` available as `this` rather than as the first argument.
+
 #### Other Utilities (`@graphql-tools/utils`)
 
 - `filterSchema`'s `fieldFilter` will now filter *all* fields across Object, Interface, and Input types. For the previous Object-only behavior, switch to the `objectFieldFilter` option.