Skip to content

Commit 526f7c5

Browse files
minor fixes from PR feedback
1 parent 4ceadba commit 526f7c5

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

src/index.ts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -742,7 +742,7 @@ export const plugin: PluginFunction<TypescriptMocksPluginConfig> = (schema, docu
742742
const { directives } = node;
743743
const hasOneOfDirective = directives.some((directive) => directive.name.value === 'oneOf');
744744

745-
if (node.fields && hasOneOfDirective) {
745+
if (node.fields && node.fields.length > 0 && hasOneOfDirective) {
746746
const field = node.fields[0];
747747
const value = generateMockValue({
748748
typeName: fieldName,
@@ -754,19 +754,15 @@ export const plugin: PluginFunction<TypescriptMocksPluginConfig> = (schema, docu
754754
mockFieldsString = ` ...(override ? override : {${field.name.value} : ${value}}),`;
755755
} else if (node.fields) {
756756
mockFieldsString = node.fields
757-
.map((field, index) => {
757+
.map((field) => {
758758
const value = generateMockValue({
759759
typeName: fieldName,
760760
fieldName: field.name.value,
761761
currentType: field.type,
762762
...sharedGenerateMockOpts,
763763
});
764764

765-
const valueWithOverride = `overrides && overrides.hasOwnProperty('${
766-
field.name.value
767-
}') ? overrides.${field.name.value}! : ${
768-
!hasOneOfDirective || index === 0 ? value : 'undefined'
769-
}`;
765+
const valueWithOverride = `overrides && overrides.hasOwnProperty('${field.name.value}') ? overrides.${field.name.value}! : ${value}`;
770766

771767
return ` ${field.name.value}: ${valueWithOverride},`;
772768
})

0 commit comments

Comments
 (0)