simplify implementation

Author: Daniel Playfair Cal

src/index.ts

@@ -1,4 +1,4 @@
-import { parse, TypeNode, ASTKindToNode, ListTypeNode, NamedTypeNode, ObjectTypeDefinitionNode, Kind } from 'graphql';
+import { parse, TypeNode, ASTKindToNode, ListTypeNode, NamedTypeNode, ObjectTypeDefinitionNode } from 'graphql';
 import * as allFakerLocales from '@faker-js/faker';
 import casual from 'casual';
 import { oldVisit, PluginFunction, resolveExternalModuleAndFn } from '@graphql-codegen/plugin-helpers';
@@ -34,6 +34,7 @@ type Options<T = TypeNode> = {
     defaultNullableToNull: boolean;
     nonNull: boolean;
     typeNamesMapping?: Record<string, string>;
+    inputOneOfTypes: Set<string>;
 };
 
 const getTerminateCircularRelationshipsConfig = ({ terminateCircularRelationships }: TypescriptMocksPluginConfig) =>
@@ -410,7 +411,7 @@ const getNamedType = (opts: Options<NamedTypeNode | ObjectTypeDefinitionNode>):
                 }
             }
 
-            if (opts.terminateCircularRelationships) {
+            if (opts.terminateCircularRelationships && !opts.inputOneOfTypes.has(opts.currentType.name.value)) {
                 return handleValueGeneration(opts, null, () => {
                     if (opts.typesPrefix) {
                         const typeNameConverter = createNameConverter(
@@ -688,6 +689,7 @@ export const plugin: PluginFunction<TypescriptMocksPluginConfig> = (schema, docu
 
     // List of types that are enums
     const types: TypeItem[] = [];
+    const inputOneOfTypes: Set<string> = new Set();
     const typeVisitor: VisitorType = {
         EnumTypeDefinition: (node) => {
             const name = node.name.value;
@@ -724,6 +726,11 @@ export const plugin: PluginFunction<TypescriptMocksPluginConfig> = (schema, docu
                 }
             }
         },
+        InputObjectTypeDefinition: (node) => {
+            if (node.directives.some((directive) => directive.name.value === 'oneOf')) {
+                inputOneOfTypes.add(node.name.value);
+            }
+        },
         ScalarTypeDefinition: (node) => {
             const name = node.name.value;
             if (!types.find((scalarType) => scalarType.name === name)) {
@@ -756,6 +763,7 @@ export const plugin: PluginFunction<TypescriptMocksPluginConfig> = (schema, docu
         typesPrefix: config.typesPrefix,
         useImplementingTypes,
         useTypeImports,
+        inputOneOfTypes,
     };
 
     const visitor: VisitorType = {
@@ -802,28 +810,12 @@ export const plugin: PluginFunction<TypescriptMocksPluginConfig> = (schema, docu
                     } else if (node.fields) {
                         mockFieldsString = node.fields
                             .map((field) => {
-                                const typeName = field.type.kind === Kind.NAMED_TYPE ? field.type.name.value : null;
-                                const fieldIsOneOfType = Boolean(
-                                    typeName &&
-                                        astNode.definitions.find(
-                                            (definition) =>
-                                                definition.kind === Kind.INPUT_OBJECT_TYPE_DEFINITION &&
-                                                definition.name.value === typeName &&
-                                                definition.directives.some(
-                                                    (directive) => directive.name.value === 'oneOf',
-                                                ),
-                                        ),
-                                );
-
                                 const value = generateMockValue({
                                     typeName: fieldName,
                                     fieldName: field.name.value,
                                     currentType: field.type,
                                     generatorMode: 'input',
                                     ...sharedGenerateMockOpts,
-                                    terminateCircularRelationships: fieldIsOneOfType
-                                        ? false
-                                        : sharedGenerateMockOpts.terminateCircularRelationships,
                                 });
 
                                 const valueWithOverride = `overrides && overrides.hasOwnProperty('${field.name.value}') ? overrides.${field.name.value}! : ${value}`;