fix: faker dynamicValues data generation (#96)

Jimmy Paolini · web-flow · commit cc8f50043f23 · 2022-09-29T16:06:25.000-04:00
Fixing a small typo where arguments were passed to the wrong function in a chain.
diff --git a/src/mockValueGenerator.ts b/src/mockValueGenerator.ts
@@ -71,7 +71,7 @@ class FakerMockValueGenerator implements MockValueGenerator {
             : faker.datatype.float({ min: 0, max: 10, precision: 0.1 });
     date = () =>
         this.dynamicValues
-            ? `faker.date.past().toISOString(1, new Date(2022, 0))`
+            ? `faker.date.past(1, new Date(2022, 0)).toISOString()`
             : `'${faker.date.past(1, new Date(2022, 0)).toISOString()}'`;
     seed = (seed: number) => faker.seed(seed);
 }
diff --git a/tests/__snapshots__/typescript-mock-data.spec.ts.snap b/tests/__snapshots__/typescript-mock-data.spec.ts.snap
@@ -959,7 +959,7 @@ export const anAvatar = (overrides?: Partial<Avatar>): Avatar => {
 export const aUser = (overrides?: Partial<User>): User => {
     return {
         id: overrides && overrides.hasOwnProperty('id') ? overrides.id! : faker.datatype.uuid(),
-        creationDate: overrides && overrides.hasOwnProperty('creationDate') ? overrides.creationDate! : faker.date.past().toISOString(1, new Date(2022, 0)),
+        creationDate: overrides && overrides.hasOwnProperty('creationDate') ? overrides.creationDate! : faker.date.past(1, new Date(2022, 0)).toISOString(),
         login: overrides && overrides.hasOwnProperty('login') ? overrides.login! : faker.lorem.word(),
         avatar: overrides && overrides.hasOwnProperty('avatar') ? overrides.avatar! : anAvatar(),
         status: overrides && overrides.hasOwnProperty('status') ? overrides.status! : Status.Online,

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ class FakerMockValueGenerator implements MockValueGenerator {`
`71`	`71`	`: faker.datatype.float({ min: 0, max: 10, precision: 0.1 });`
`72`	`72`	`date = () =>`
`73`	`73`	`this.dynamicValues`
`74`		- ? `faker.date.past().toISOString(1, new Date(2022, 0))`
	`74`	+ ? `faker.date.past(1, new Date(2022, 0)).toISOString()`
`75`	`75`	: `'${faker.date.past(1, new Date(2022, 0)).toISOString()}'`;
`76`	`76`	`seed = (seed: number) => faker.seed(seed);`
`77`	`77`	`}`