Merge pull request #131 from arduino-libraries/use-valgrind

Run unit tests via valgrind to check for memory leaks

Author: aentinger

.github/workflows/unit-tests.yml

@@ -25,13 +25,17 @@ jobs:
       - name: Checkout
         uses: actions/checkout@v2
 
+      - name: Install valgrind
+        run: |
+          sudo apt-get install valgrind
+
       - name: Run unit tests
         run: |
           mkdir "$BUILD_PATH"
           cd "$BUILD_PATH"
           cmake ..
           make
-          bin/testArduinoIoTCloud
+          valgrind --leak-check=yes --error-exitcode=1 bin/testArduinoIoTCloud
 
       - name: Check code coverage
         run: |

extras/test/src/test_callback.cpp

@@ -162,7 +162,7 @@ SCENARIO("After a connection/reconnection an incoming cbor payload is processed
 SCENARIO("Primitive property: After a connection/reconnection an incoming cbor payload is processed and the synchronization callback is executed. The sync callback applies the AUTO_SYNC policy (the most recent value between the local one and the cloud one is finally assigned to the property). The onUpdate function is called if the cloud value is the most recent one. In this scenario the most updated value is the cloud one.") {
   GIVEN("CloudProtocol::V2") {
     bool test = true;
-    ArduinoCloudProperty *p = new CloudWrapperBool(test);
+    std::unique_ptr<ArduinoCloudProperty> p(new CloudWrapperBool(test));
     sync_callback_called = false;
     change_callback_called = false;
 
@@ -192,7 +192,7 @@ SCENARIO("Primitive property: After a connection/reconnection an incoming cbor p
 SCENARIO("Primitive property: After a connection/reconnection an incoming cbor payload is processed and the synchronization callback is executed. The sync callback apply the AUTO_SYNC policy (the most recent value between the local one and the cloud one is finally assigned to the property). The onUpdate function is called if the cloud value is the most recent one. In this scenario the most updated value is the local one.") {
   GIVEN("CloudProtocol::V2") {
     bool test = true;
-    ArduinoCloudProperty *p = new CloudWrapperBool(test);
+    std::unique_ptr<ArduinoCloudProperty> p(new CloudWrapperBool(test));
     sync_callback_called = false;
     change_callback_called = false;
 

extras/test/src/test_decode.cpp

@@ -8,6 +8,8 @@
 
 #include <catch.hpp>
 
+#include <memory>
+
 #include <util/CBORTestUtil.h>
 #include <ArduinoCloudThing.h>
 #include "types/CloudWrapperBool.h"
@@ -483,15 +485,15 @@ SCENARIO("Arduino Cloud Properties are decoded", "[ArduinoCloudThing::decode]")
         String str_test;
         str_test = "str_test";
 
-        ArduinoCloudProperty *i = new CloudWrapperInt(int_test);
-        ArduinoCloudProperty *b = new CloudWrapperBool(bool_test);
-        ArduinoCloudProperty *f = new CloudWrapperFloat(float_test);
-        ArduinoCloudProperty *s = new CloudWrapperString(str_test);
+        std::unique_ptr<ArduinoCloudProperty> i(new CloudWrapperInt(int_test));
+        std::unique_ptr<ArduinoCloudProperty> b(new CloudWrapperBool(bool_test));
+        std::unique_ptr<ArduinoCloudProperty> f(new CloudWrapperFloat(float_test));
+        std::unique_ptr<ArduinoCloudProperty> s(new CloudWrapperString(str_test));
 
-        thing.addPropertyReal(*b,  "bool_test",  Permission::ReadWrite).onSync(CLOUD_WINS);
-        thing.addPropertyReal(*i,   "int_test",   Permission::ReadWrite).onSync(CLOUD_WINS);
+        thing.addPropertyReal(*b, "bool_test",  Permission::ReadWrite).onSync(CLOUD_WINS);
+        thing.addPropertyReal(*i, "int_test",   Permission::ReadWrite).onSync(CLOUD_WINS);
         thing.addPropertyReal(*f, "float_test", Permission::ReadWrite).onSync(CLOUD_WINS);
-        thing.addPropertyReal(*s,   "str_test",   Permission::ReadWrite).onSync(CLOUD_WINS);
+        thing.addPropertyReal(*s, "str_test",   Permission::ReadWrite).onSync(CLOUD_WINS);
 
         thing.updateTimestampOnLocallyChangedProperties();
 

extras/test/src/test_encode.cpp

@@ -8,6 +8,8 @@
 
 #include <catch.hpp>
 
+#include <memory>
+
 #include <util/CBORTestUtil.h>
 #include <ArduinoCloudThing.h>
 #include "types/CloudWrapperBool.h"
@@ -377,15 +379,15 @@ SCENARIO("Arduino Cloud Properties are encoded", "[ArduinoCloudThing::encode]")
       String str_test;
       str_test = "str_test";
 
-      ArduinoCloudProperty *i = new CloudWrapperInt(int_test);
-      ArduinoCloudProperty *b = new CloudWrapperBool(bool_test);
-      ArduinoCloudProperty *f = new CloudWrapperFloat(float_test);
-      ArduinoCloudProperty *s = new CloudWrapperString(str_test);
+      std::unique_ptr<ArduinoCloudProperty> i(new CloudWrapperInt(int_test));
+      std::unique_ptr<ArduinoCloudProperty> b(new CloudWrapperBool(bool_test));
+      std::unique_ptr<ArduinoCloudProperty> f(new CloudWrapperFloat(float_test));
+      std::unique_ptr<ArduinoCloudProperty> s(new CloudWrapperString(str_test));
 
-      thing.addPropertyReal(*i,   "int_test",   Permission::ReadWrite);
-      thing.addPropertyReal(*b,  "bool_test",  Permission::ReadWrite);
+      thing.addPropertyReal(*i, "int_test",   Permission::ReadWrite);
+      thing.addPropertyReal(*b, "bool_test",  Permission::ReadWrite);
       thing.addPropertyReal(*f, "float_test", Permission::ReadWrite);
-      thing.addPropertyReal(*s,   "str_test",   Permission::ReadWrite);
+      thing.addPropertyReal(*s, "str_test",   Permission::ReadWrite);
 
       thing.updateTimestampOnLocallyChangedProperties();