Skip to content

Commit 04a7cd2

Browse files
committed
Extracting calling of callback functions into state transition detection logic
1 parent 9a3b4b3 commit 04a7cd2

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

src/ArduinoIoTCloudTCP.cpp

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -304,8 +304,6 @@ ArduinoIoTConnectionStatus ArduinoIoTCloudTCP::checkCloudConnection()
304304
if (ret == CONNECT_SUCCESS)
305305
{
306306
next_iot_status = ArduinoIoTConnectionStatus::CONNECTED;
307-
execCloudEventCallback(ArduinoIoTCloudEvent::CONNECT);
308-
309307
CloudSerial.begin(9600);
310308
CloudSerial.println("Hello from Cloud Serial!");
311309
}
@@ -322,8 +320,6 @@ ArduinoIoTConnectionStatus ArduinoIoTCloudTCP::checkCloudConnection()
322320
if (reconnect() == CONNECT_SUCCESS)
323321
{
324322
next_iot_status = ArduinoIoTConnectionStatus::CONNECTED;
325-
execCloudEventCallback(ArduinoIoTCloudEvent::CONNECT);
326-
327323
CloudSerial.begin(9600);
328324
CloudSerial.println("Hello from Cloud Serial!");
329325
}
@@ -336,16 +332,17 @@ ArduinoIoTConnectionStatus ArduinoIoTCloudTCP::checkCloudConnection()
336332
{
337333
next_iot_status = ArduinoIoTConnectionStatus::DISCONNECTED;
338334
_mqtt_data_request_retransmit = true;
339-
execCloudEventCallback(ArduinoIoTCloudEvent::DISCONNECT);
340335
}
341336
}
342337
break;
343338
}
344339

345340
if(next_iot_status != _iotStatus)
346341
{
342+
printConnectionStatus(next_iot_status);
343+
if (next_iot_status == ArduinoIoTConnectionStatus::DISCONNECTED) execCloudEventCallback(ArduinoIoTCloudEvent::DISCONNECT);
344+
else if(next_iot_status == ArduinoIoTConnectionStatus::CONNECTED) execCloudEventCallback(ArduinoIoTCloudEvent::CONNECT);
347345
_iotStatus = next_iot_status;
348-
printConnectionStatus(_iotStatus);
349346
}
350347

351348
return _iotStatus;

0 commit comments

Comments
 (0)