Skip to content

Commit 2ec56e6

Browse files
committed
Adding virtual/override keywords and missing ctors where necessary
1 parent 90eec00 commit 2ec56e6

File tree

4 files changed

+23
-18
lines changed

4 files changed

+23
-18
lines changed

src/ArduinoIoTCloud.h

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,10 +77,13 @@ class ArduinoIoTCloudClass
7777
{
7878
public:
7979

80+
virtual ~ArduinoIoTCloudClass() { }
81+
82+
8083
virtual int connect () = 0;
8184
virtual bool disconnect () = 0;
8285
virtual void update () = 0;
83-
virtual int connected () = 0;
86+
virtual int connected () = 0;
8487
virtual void printDebugInfo() = 0;
8588

8689
inline void setThingId (String const thing_id) { _thing_id = thing_id; };

src/ArduinoIoTCloudLPWAN.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,6 @@
3737
ArduinoIoTCloudLPWAN::ArduinoIoTCloudLPWAN() :
3838
_connection(NULL) {}
3939

40-
ArduinoIoTCloudLPWAN::~ArduinoIoTCloudLPWAN() {
41-
}
42-
4340
/******************************************************************************
4441
* PUBLIC MEMBER FUNCTIONS
4542
******************************************************************************/

src/ArduinoIoTCloudLPWAN.h

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -37,14 +37,17 @@ static uint8_t const DEFAULT_CBOR_LORA_MSG_SIZE = 255;
3737

3838
class ArduinoIoTCloudLPWAN : public ArduinoIoTCloudClass {
3939
public:
40-
ArduinoIoTCloudLPWAN();
41-
~ArduinoIoTCloudLPWAN();
42-
int connect();
43-
bool disconnect();
44-
int connected();
45-
void update();
40+
41+
ArduinoIoTCloudLPWAN();
42+
virtual ~ArduinoIoTCloudLPWAN() { }
43+
44+
virtual int connect () override;
45+
virtual bool disconnect () override;
46+
virtual void update () override;
47+
virtual int connected () override;
48+
virtual void printDebugInfo() override;
49+
4650
ArduinoIoTConnectionStatus connectionCheck();
47-
void printDebugInfo();
4851
int begin(ConnectionHandler& connection, bool retry = false);
4952
inline ConnectionHandler* getConnection() {
5053
return _connection;

src/ArduinoIoTCloudTCP.h

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -52,13 +52,15 @@ class ArduinoIoTCloudTCP: public ArduinoIoTCloudClass {
5252

5353
static const int TIMEOUT_FOR_LASTVALUES_SYNC = 10000;
5454

55-
ArduinoIoTCloudTCP();
56-
~ArduinoIoTCloudTCP();
57-
int connect();
58-
bool disconnect();
59-
int connected();
60-
void update();
61-
void printDebugInfo();
55+
ArduinoIoTCloudTCP();
56+
virtual ~ArduinoIoTCloudTCP();
57+
58+
virtual int connect () override;
59+
virtual bool disconnect () override;
60+
virtual void update () override;
61+
virtual int connected () override;
62+
virtual void printDebugInfo() override;
63+
6264
#ifdef BOARD_HAS_ECCX08
6365
int begin(ConnectionHandler & connection, String brokerAddress = DEFAULT_BROKER_ADDRESS_SECURE_AUTH, uint16_t brokerPort = DEFAULT_BROKER_PORT_SECURE_AUTH);
6466
#else

0 commit comments

Comments
 (0)