Skip to content

Commit 5631899

Browse files
committed
Move initialisation/configuration code for MQTT client from func mqttClientBegin to begin which makes puts the change closer to where it actually matters
1 parent 740c1be commit 5631899

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

src/ArduinoIoTCloudTCP.cpp

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -110,10 +110,13 @@ int ArduinoIoTCloudTCP::begin(String brokerAddress, uint16_t brokerPort) {
110110
#endif
111111

112112
_mqttClient = new MqttClient(*_sslClient);
113-
114113
#ifdef BOARD_ESP
115114
_mqttClient->setUsernamePassword(_device_id, _password);
116115
#endif
116+
_mqttClient->onMessage(ArduinoIoTCloudTCP::onMessage);
117+
_mqttClient->setKeepAliveInterval(30 * 1000);
118+
_mqttClient->setConnectionTimeout(1500);
119+
_mqttClient->setId(_device_id.c_str());
117120

118121
mqttClientBegin();
119122

@@ -346,12 +349,6 @@ void ArduinoIoTCloudTCP::mqttClientBegin() {
346349
_shadowTopicIn = "/a/t/" + _thing_id + "/shadow/i";
347350
_shadowTopicOut = "/a/t/" + _thing_id + "/shadow/o";
348351
}
349-
350-
// use onMessage as callback for received mqtt messages
351-
_mqttClient->onMessage(ArduinoIoTCloudTCP::onMessage);
352-
_mqttClient->setKeepAliveInterval(30 * 1000);
353-
_mqttClient->setConnectionTimeout(1500);
354-
_mqttClient->setId(_device_id.c_str());
355352
}
356353

357354
int ArduinoIoTCloudTCP::writeProperties(const byte data[], int length) {

0 commit comments

Comments
 (0)