Since the cloud event callback argument is never used the void * parameter for is removed

Author: aentinger

src/ArduinoIoTCloud.cpp

@@ -150,10 +150,10 @@ ArduinoCloudProperty& ArduinoIoTCloudClass::addPropertyReal(String& property, St
  * PRIVATE MEMBER FUNCTIONS
  ******************************************************************************/
 
-void ArduinoIoTCloudClass::execCloudEventCallback(OnCloudEventCallback& callback, void* callback_arg)
+void ArduinoIoTCloudClass::execCloudEventCallback(OnCloudEventCallback& callback)
 {
   if (callback) {
-    (*callback)(callback_arg);
+    (*callback)();
   }
 }
 

src/ArduinoIoTCloud.h

@@ -67,7 +67,7 @@ enum class ArduinoIoTCloudEvent
   SYNC, CONNECT, DISCONNECT
 };
 
-typedef void (*OnCloudEventCallback)(void * /* arg */);
+typedef void (*OnCloudEventCallback)(void);
 
 /******************************************************************************
  * CLASS DECLARATION
@@ -138,7 +138,7 @@ class ArduinoIoTCloudClass
     OnCloudEventCallback _on_connect_event_callback    = NULL;
     OnCloudEventCallback _on_disconnect_event_callback = NULL;
 
-    static void execCloudEventCallback(OnCloudEventCallback & callback, void * callback_arg);
+    static void execCloudEventCallback(OnCloudEventCallback & callback);
     static void printConnectionStatus(ArduinoIoTConnectionStatus status);
 
   private:

src/ArduinoIoTCloudLPWAN.cpp

@@ -91,7 +91,7 @@ void ArduinoIoTCloudLPWAN::update() {
   sendPropertiesToCloud();
 
 
-  execCloudEventCallback(_on_sync_event_callback, 0 /* callback_arg */);
+  execCloudEventCallback(_on_sync_event_callback);
 
 }
 
@@ -124,7 +124,7 @@ ArduinoIoTConnectionStatus ArduinoIoTCloudLPWAN::connectionCheck() {
         if (_connection->getStatus() != NetworkConnectionState::CONNECTED) {
           _iotStatus = ArduinoIoTConnectionStatus::DISCONNECTED;
           printConnectionStatus(_iotStatus);
-          execCloudEventCallback(_on_disconnect_event_callback, 0 /* callback_arg - e.g. could be error code casted to void * */);
+          execCloudEventCallback(_on_disconnect_event_callback);
         }
       }
       break;
@@ -150,7 +150,7 @@ ArduinoIoTConnectionStatus ArduinoIoTCloudLPWAN::connectionCheck() {
         if (net_status == NetworkConnectionState::CONNECTED) {
           _iotStatus = ArduinoIoTConnectionStatus::CONNECTED;
           printConnectionStatus(_iotStatus);
-          execCloudEventCallback(_on_connect_event_callback, 0 /* callback_arg */);
+          execCloudEventCallback(_on_connect_event_callback);
         }
 
       }

src/ArduinoIoTCloudTCP.cpp

@@ -188,7 +188,7 @@ void ArduinoIoTCloudTCP::update() {
       }
       break;
     case ArduinoIoTSynchronizationStatus::SYNC_STATUS_VALUES_PROCESSED: {
-        execCloudEventCallback(_on_sync_event_callback, 0 /* callback_arg */);
+        execCloudEventCallback(_on_sync_event_callback);
         _syncStatus = ArduinoIoTSynchronizationStatus::SYNC_STATUS_SYNCHRONIZED;
       }
       break;
@@ -302,7 +302,7 @@ ArduinoIoTConnectionStatus ArduinoIoTCloudTCP::checkCloudConnection()
           _iotStatus = ArduinoIoTConnectionStatus::DISCONNECTED;
           _mqtt_data_request_retransmit = true;
           printConnectionStatus(_iotStatus);
-          execCloudEventCallback(_on_disconnect_event_callback, 0 /* callback_arg - e.g. could be error code casted to void * */);
+          execCloudEventCallback(_on_disconnect_event_callback);
         }
       }
       break;
@@ -317,7 +317,7 @@ ArduinoIoTConnectionStatus ArduinoIoTCloudTCP::checkCloudConnection()
         if (ret_code_reconnect == CONNECT_SUCCESS) {
           _iotStatus = ArduinoIoTConnectionStatus::CONNECTED;
           printConnectionStatus(_iotStatus);
-          execCloudEventCallback(_on_connect_event_callback, 0 /* callback_arg */);
+          execCloudEventCallback(_on_connect_event_callback);
           CloudSerial.begin(9600);
           CloudSerial.println("Hello from Cloud Serial!");
         }
@@ -329,7 +329,7 @@ ArduinoIoTConnectionStatus ArduinoIoTCloudTCP::checkCloudConnection()
         if (ret_code_connect == CONNECT_SUCCESS) {
           _iotStatus = ArduinoIoTConnectionStatus::CONNECTED;
           printConnectionStatus(_iotStatus);
-          execCloudEventCallback(_on_connect_event_callback, 0 /* callback_arg */);
+          execCloudEventCallback(_on_connect_event_callback);
           CloudSerial.begin(9600);
           CloudSerial.println("Hello from Cloud Serial!");
         } else if (ret_code_connect == CONNECT_FAILURE_SUBSCRIBE) {