When the OTAStorage::init operation fails the OTA logic should transition to OTAState::Error and indicate that the error is of type OTAError::StorageInitFailed

Author: aentinger

extras/test/src/test_OTALogic.cpp

@@ -49,6 +49,38 @@ void simulateOTABinaryReception(OTALogic & ota_logic, OTAData const & ota_test_d
    TEST CODE
  **************************************************************************************/
 
+TEST_CASE("OTAStorage initialisation failed ", "[OTAStorage::init() -> returns false]")
+{
+  Mock<OTAStorage> ota_storage;
+
+  /* Configure mock object */
+  When(Method(ota_storage, init)).Return(false);
+  Fake(Method(ota_storage, open));
+  Fake(Method(ota_storage, write));
+  Fake(Method(ota_storage, close));
+  Fake(Method(ota_storage, remove));
+  Fake(Method(ota_storage, deinit));
+
+
+  /* Perform test */
+  OTALogic ota_logic(ota_storage.get());
+
+  WHEN("OTALogic::update() is called ")
+  {
+    ota_logic.update();
+    THEN("The OTA logic should be in the 'Error' state")
+    {
+      REQUIRE(ota_logic.state()  == OTAState::Error);
+    }
+    THEN("The OTA error should be set to OTAError::StorageInitFailed")
+    {
+      REQUIRE(ota_logic.update() == OTAError::StorageInitFailed);
+    }
+  }
+}
+
+/**************************************************************************************/
+
 TEST_CASE("Valid OTA data is received ", "[OTALogic]")
 {
   Mock<OTAStorage> ota_storage;
@@ -98,6 +130,8 @@ TEST_CASE("Valid OTA data is received ", "[OTALogic]")
   }
 }
 
+/**************************************************************************************/
+
 TEST_CASE("Invalid OTA data is received ", "[OTALogic - CRC wrong]")
 {
   Mock<OTAStorage> ota_storage;

src/utility/ota/OTALogic.cpp

@@ -94,8 +94,10 @@ OTAState OTALogic::handle_Init()
 {
   if (_ota_storage.init()) {
     return OTAState::Idle;
+  } else {
+    _ota_error = OTAError::StorageInitFailed;
+    return OTAState::Error;
   }
-  return OTAState::Error;
 }
 
 OTAState OTALogic::handle_Idle()

src/utility/ota/OTALogic.h

@@ -43,7 +43,7 @@ enum class OTAState
 
 enum class OTAError
 {
-  None, ChecksumMismatch
+  None, StorageInitFailed, ChecksumMismatch
 };
 
 /******************************************************************************