Skip to content

Commit 98fb05f

Browse files
committed
Removing writeStdout/writeProperties/writeShadowOut from being pure virtual functions within the ArduinoIoTCloud base class
There is no need for this since the communication mechanism is different for TCP enabled and LoRa based boards. Removing of both writeStdout and writeShadowOut since they are not required for LoRa boards (there isn't even MQTT in play)
1 parent cd3b1fc commit 98fb05f

File tree

3 files changed

+0
-29
lines changed

3 files changed

+0
-29
lines changed

src/ArduinoIoTCloud.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -128,10 +128,6 @@ class ArduinoIoTCloudClass
128128

129129
protected:
130130

131-
virtual int writeStdout(const byte data[], int length) = 0;
132-
virtual int writeProperties(const byte data[], int length) = 0;
133-
virtual int writeShadowOut(const byte data[], int length) = 0;
134-
135131
inline ArduinoIoTConnectionStatus getIoTStatus() { return _iotStatus; }
136132

137133
String _device_id = "";

src/ArduinoIoTCloudLPWAN.cpp

Lines changed: 0 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -180,29 +180,6 @@ int ArduinoIoTCloudLPWAN::writeProperties(const byte data[], int length) {
180180
return 1;
181181
}
182182

183-
int ArduinoIoTCloudLPWAN::writeStdout(const byte data[], int length) {
184-
int retcode = _connection->write(data, length);
185-
int i = 0;
186-
while (_retryEnable && retcode < 0 && i < _maxNumRetry) {
187-
delay(_intervalRetry);
188-
retcode = _connection->write(data, length);
189-
i++;
190-
}
191-
192-
return 1;
193-
}
194-
195-
int ArduinoIoTCloudLPWAN::writeShadowOut(const byte data[], int length) {
196-
int retcode = _connection->write(data, length);
197-
int i = 0;
198-
while (_retryEnable && retcode < 0 && i < _maxNumRetry) {
199-
delay(_intervalRetry);
200-
retcode = _connection->write(data, length);
201-
i++;
202-
}
203-
return 1;
204-
}
205-
206183
/******************************************************************************
207184
* PRIVATE MEMBER FUNCTIONS
208185
******************************************************************************/

src/ArduinoIoTCloudLPWAN.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,7 @@ class ArduinoIoTCloudLPWAN : public ArduinoIoTCloudClass {
7474
}
7575

7676
protected:
77-
int writeStdout(const byte data[], int length);
7877
int writeProperties(const byte data[], int length);
79-
int writeShadowOut(const byte data[], int length);
8078

8179
private:
8280
ConnectionHandler* _connection;

0 commit comments

Comments
 (0)