When the writing to the file on the OTA storage device for the update file fails then the OTA logic should transition to the OTAState::Error state and set OTAError::StorageWritedFailed

Author: aentinger

extras/test/src/test_OTALogic.cpp

@@ -114,6 +114,42 @@ TEST_CASE("OTAStorage opening of storage file fails ", "[OTAStorage::open() -> r
   }
 }
 
+
+/**************************************************************************************/
+
+TEST_CASE("OTAStorage writing to storage file fails ", "[OTAStorage::write() -> fails]")
+{
+  Mock<OTAStorage> ota_storage;
+
+  /* Configure mock object */
+  When(Method(ota_storage, init)).Return(true);
+  When(Method(ota_storage, open)).Return(true);
+  When(Method(ota_storage, write)).AlwaysDo([](uint8_t const * const /* buf */, size_t const /* num_bytes */) -> size_t { return 0 /* should return num_bytes in case of succes */;});
+  Fake(Method(ota_storage, close));
+  Fake(Method(ota_storage, remove));
+  Fake(Method(ota_storage, deinit));
+
+
+  /* Perform test */
+  OTALogic ota_logic(ota_storage.get());
+
+  WHEN("OTALogic::update() is called and some bytes have been received")
+  {
+    uint8_t const SOME_FAKE_DATA[16] = {0};
+    ota_logic.onOTADataReceived(SOME_FAKE_DATA, sizeof(SOME_FAKE_DATA));
+    ota_logic.update();
+
+    THEN("The OTA logic should be in the 'Error' state")
+    {
+      REQUIRE(ota_logic.state()  == OTAState::Error);
+    }
+    THEN("The OTA error should be set to OTAError::StorageWriteFailed")
+    {
+      REQUIRE(ota_logic.error() == OTAError::StorageWriteFailed);
+    }
+  }
+}
+
 /**************************************************************************************/
 
 TEST_CASE("Valid OTA data is received ", "[OTALogic]")

src/utility/ota/OTALogic.cpp

@@ -174,7 +174,9 @@ OTAState OTALogic::handle_WaitForBinary()
 OTAState OTALogic::handle_BinaryReceived()
 {
   /* Write to OTA storage */
-  if(_ota_storage.write(_mqtt_ota_buf.buf, _mqtt_ota_buf.num_bytes) != _mqtt_ota_buf.num_bytes) {
+  if(_ota_storage.write(_mqtt_ota_buf.buf, _mqtt_ota_buf.num_bytes) != _mqtt_ota_buf.num_bytes)
+  {
+    _ota_error = OTAError::StorageWriteFailed;
     return OTAState::Error;
   }
 

src/utility/ota/OTALogic.h

@@ -43,7 +43,7 @@ enum class OTAState
 
 enum class OTAError
 {
-  None, StorageInitFailed, StorageOpenFailed, ChecksumMismatch
+  None, StorageInitFailed, StorageOpenFailed, StorageWriteFailed, ChecksumMismatch
 };
 
 /******************************************************************************