OTA: make fetch blocking for real and also wait for data

pennam · pennam · commit b8d5305f22a6 · 2024-06-10T09:01:06.000+02:00
diff --git a/src/ota/interface/OTAInterfaceDefault.cpp b/src/ota/interface/OTAInterfaceDefault.cpp
@@ -94,7 +94,9 @@ OTACloudProcessInterface::State OTADefaultCloudProcessInterface::fetch() {
 
   do {
     if(http_client->available() == 0) {
-      goto exit;
+      /* Avoid tight loop and allow yield */
+      delay(1);
+      continue;
     }
 
     http_res = http_client->read(context->buffer, context->buf_len);

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,9 @@ OTACloudProcessInterface::State OTADefaultCloudProcessInterface::fetch() {`
`94`	`94`
`95`	`95`	`do {`
`96`	`96`	`if(http_client->available() == 0) {`
`97`		`- goto exit;`
	`97`	`+ /* Avoid tight loop and allow yield */`
	`98`	`+ delay(1);`
	`99`	`+ continue;`
`98`	`100`	`}`
`99`	`101`
`100`	`102`	`http_res = http_client->read(context->buffer, context->buf_len);`