Skip to content

Prepare for release #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 12, 2025
Merged

Prepare for release #9

merged 3 commits into from
May 12, 2025

Conversation

@fabik111
Copy link
Collaborator

@fabik111 fabik111 commented May 6, 2025

No description provided.

@github-actions
Copy link

github-actions bot commented May 6, 2025

Memory usage change @ 3fd301c

Board flash % RAM for global variables %
arduino:mbed_giga:giga 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nano:nanorp2040connect 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_nicla:nicla_vision 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_opta:opta 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:renesas_uno:unor4wifi 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:mkrwifi1010 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/NetworkConfiguratorDemo
flash		 % examples/NetworkConfiguratorDemo
RAM for global variables		 %
arduino:mbed_giga:giga 0 0.0 0 0.0
arduino:mbed_nano:nanorp2040connect 0 0.0 0 0.0
arduino:mbed_nicla:nicla_vision 0 0.0 0 0.0
arduino:mbed_opta:opta 0 0.0 0 0.0
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 0 0.0 0 0.0
arduino:renesas_uno:unor4wifi 0 0.0 0 0.0
arduino:samd:mkrwifi1010 0 0.0 0 0.0
arduino:samd:nano_33_iot 0 0.0 0 0.0
Click for full report CSV 
Board,examples/NetworkConfiguratorDemo<br>flash,%,examples/NetworkConfiguratorDemo<br>RAM for global variables,%
arduino:mbed_giga:giga,0,0.0,0,0.0
arduino:mbed_nano:nanorp2040connect,0,0.0,0,0.0
arduino:mbed_nicla:nicla_vision,0,0.0,0,0.0
arduino:mbed_opta:opta,0,0.0,0,0.0
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,0,0.0,0,0.0
arduino:renesas_uno:unor4wifi,0,0.0,0,0.0
arduino:samd:mkrwifi1010,0,0.0,0,0.0
arduino:samd:nano_33_iot,0,0.0,0,0.0

@codecov
Copy link

codecov bot commented May 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.98%. Comparing base (f6f40bc) to head (5a27b1a).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage   75.98%   75.98%           
=======================================
  Files           4        4           
  Lines         304      304           
=======================================
  Hits          231      231           
  Misses         73       73

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented May 8, 2025

Memory usage change @ 9792dca

Board flash % RAM for global variables %
arduino:mbed_giga:giga N/A N/A N/A N/A
arduino:mbed_nano:nanorp2040connect N/A N/A N/A N/A
arduino:mbed_nicla:nicla_vision N/A N/A N/A N/A
arduino:mbed_opta:opta N/A N/A N/A N/A
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 N/A N/A N/A N/A
arduino:renesas_uno:unor4wifi N/A N/A N/A N/A
arduino:samd:mkrwifi1010 N/A N/A N/A N/A
arduino:samd:nano_33_iot N/A N/A N/A N/A
Click for full report table
Board examples/NetworkConfiguratorDemo
flash		 % examples/NetworkConfiguratorDemo
RAM for global variables		 %
arduino:mbed_giga:giga N/A N/A N/A N/A
arduino:mbed_nano:nanorp2040connect N/A N/A N/A N/A
arduino:mbed_nicla:nicla_vision N/A N/A N/A N/A
arduino:mbed_opta:opta N/A N/A N/A N/A
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 N/A N/A N/A N/A
arduino:renesas_uno:unor4wifi N/A N/A N/A N/A
arduino:samd:mkrwifi1010 N/A N/A N/A N/A
arduino:samd:nano_33_iot N/A N/A N/A N/A
Click for full report CSV 
Board,examples/NetworkConfiguratorDemo<br>flash,%,examples/NetworkConfiguratorDemo<br>RAM for global variables,%
arduino:mbed_giga:giga,N/A,N/A,N/A,N/A
arduino:mbed_nano:nanorp2040connect,N/A,N/A,N/A,N/A
arduino:mbed_nicla:nicla_vision,N/A,N/A,N/A,N/A
arduino:mbed_opta:opta,N/A,N/A,N/A,N/A
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,N/A,N/A,N/A,N/A
arduino:renesas_uno:unor4wifi,N/A,N/A,N/A,N/A
arduino:samd:mkrwifi1010,N/A,N/A,N/A,N/A
arduino:samd:nano_33_iot,N/A,N/A,N/A,N/A

@fabik111 fabik111 force-pushed the prepare-for-release branch from 9792dca to 4c6c46e Compare May 12, 2025 08:07
@github-actions
Copy link

Memory usage change @ 4c6c46e

Board flash % RAM for global variables %
arduino:mbed_giga:giga N/A N/A N/A N/A
arduino:mbed_nano:nanorp2040connect N/A N/A N/A N/A
arduino:mbed_nicla:nicla_vision N/A N/A N/A N/A
arduino:mbed_opta:opta N/A N/A N/A N/A
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 N/A N/A N/A N/A
arduino:renesas_uno:unor4wifi N/A N/A N/A N/A
arduino:samd:mkrwifi1010 N/A N/A N/A N/A
arduino:samd:nano_33_iot N/A N/A N/A N/A
Click for full report table
Board examples/NetworkConfiguratorDemo
flash		 % examples/NetworkConfiguratorDemo
RAM for global variables		 %
arduino:mbed_giga:giga N/A N/A N/A N/A
arduino:mbed_nano:nanorp2040connect N/A N/A N/A N/A
arduino:mbed_nicla:nicla_vision N/A N/A N/A N/A
arduino:mbed_opta:opta N/A N/A N/A N/A
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 N/A N/A N/A N/A
arduino:renesas_uno:unor4wifi N/A N/A N/A N/A
arduino:samd:mkrwifi1010 N/A N/A N/A N/A
arduino:samd:nano_33_iot N/A N/A N/A N/A
Click for full report CSV 
Board,examples/NetworkConfiguratorDemo<br>flash,%,examples/NetworkConfiguratorDemo<br>RAM for global variables,%
arduino:mbed_giga:giga,N/A,N/A,N/A,N/A
arduino:mbed_nano:nanorp2040connect,N/A,N/A,N/A,N/A
arduino:mbed_nicla:nicla_vision,N/A,N/A,N/A,N/A
arduino:mbed_opta:opta,N/A,N/A,N/A,N/A
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,N/A,N/A,N/A,N/A
arduino:renesas_uno:unor4wifi,N/A,N/A,N/A,N/A
arduino:samd:mkrwifi1010,N/A,N/A,N/A,N/A
arduino:samd:nano_33_iot,N/A,N/A,N/A,N/A

@fabik111 fabik111 requested a review from Copilot May 12, 2025 12:03
Copilot AI reviewed May 12, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prepares the release by updating include paths to use the new connectionHandlerModels locations instead of the legacy settings directories. The key changes include:

  • Replacing all instances of "#include <settings/…>" with "#include <connectionHandlerModels/settings…>".
  • Removing obsolete include directives that reference settings_default from files where they're no longer needed.
  • Updating the GitHub workflow file to use package names rather than URLs for dependency resolution.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/configuratorAgents/agents/boardConfigurationProtocol/cbor/ProvisioningMessage.h Updated include path for settings
src/configuratorAgents/agents/boardConfigurationProtocol/cbor/Decoder.cpp Updated include path for settings_default
src/configuratorAgents/agents/boardConfigurationProtocol/CBORAdapter.h Updated include path for settings
src/configuratorAgents/agents/boardConfigurationProtocol/CBORAdapter.cpp Removed redundant include for settings_default
src/configuratorAgents/agents/ConfiguratorAgent.h Removed obsolete settings include
src/configuratorAgents/MessagesDefinitions.h Updated include path for settings
src/configuratorAgents/AgentsManager.cpp Removed obsolete settings include
src/Arduino_NetworkConfigurator.h Updated include path for settings
README.md Updated example code and documentation to reflect changes
.github/workflows/compile-examples.yml Dependencies are now referenced by name

@fabik111 fabik111 requested a review from pennam May 12, 2025 12:03
@fabik111 fabik111 force-pushed the prepare-for-release branch from 4c6c46e to 2c1fd9c Compare May 12, 2025 12:47
@github-actions
Copy link

Memory usage change @ 2c1fd9c

Board flash % RAM for global variables %
arduino:mbed_giga:giga N/A N/A N/A N/A
arduino:mbed_nano:nanorp2040connect N/A N/A N/A N/A
arduino:mbed_nicla:nicla_vision N/A N/A N/A N/A
arduino:mbed_opta:opta N/A N/A N/A N/A
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 N/A N/A N/A N/A
arduino:renesas_uno:unor4wifi N/A N/A N/A N/A
arduino:samd:mkrwifi1010 N/A N/A N/A N/A
arduino:samd:nano_33_iot N/A N/A N/A N/A
Click for full report table
Board examples/NetworkConfiguratorDemo
flash		 % examples/NetworkConfiguratorDemo
RAM for global variables		 %
arduino:mbed_giga:giga N/A N/A N/A N/A
arduino:mbed_nano:nanorp2040connect N/A N/A N/A N/A
arduino:mbed_nicla:nicla_vision N/A N/A N/A N/A
arduino:mbed_opta:opta N/A N/A N/A N/A
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 N/A N/A N/A N/A
arduino:renesas_uno:unor4wifi N/A N/A N/A N/A
arduino:samd:mkrwifi1010 N/A N/A N/A N/A
arduino:samd:nano_33_iot N/A N/A N/A N/A
Click for full report CSV 
Board,examples/NetworkConfiguratorDemo<br>flash,%,examples/NetworkConfiguratorDemo<br>RAM for global variables,%
arduino:mbed_giga:giga,N/A,N/A,N/A,N/A
arduino:mbed_nano:nanorp2040connect,N/A,N/A,N/A,N/A
arduino:mbed_nicla:nicla_vision,N/A,N/A,N/A,N/A
arduino:mbed_opta:opta,N/A,N/A,N/A,N/A
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,N/A,N/A,N/A,N/A
arduino:renesas_uno:unor4wifi,N/A,N/A,N/A,N/A
arduino:samd:mkrwifi1010,N/A,N/A,N/A,N/A
arduino:samd:nano_33_iot,N/A,N/A,N/A,N/A

@github-actions
Copy link

Memory usage change @ 5a27b1a

Board flash % RAM for global variables %
arduino:mbed_giga:giga N/A N/A N/A N/A
arduino:mbed_nano:nanorp2040connect N/A N/A N/A N/A
arduino:mbed_nicla:nicla_vision N/A N/A N/A N/A
arduino:mbed_opta:opta N/A N/A N/A N/A
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 N/A N/A N/A N/A
arduino:renesas_uno:unor4wifi N/A N/A N/A N/A
arduino:samd:mkrwifi1010 N/A N/A N/A N/A
arduino:samd:nano_33_iot N/A N/A N/A N/A
Click for full report table
Board examples/NetworkConfiguratorDemo
flash		 % examples/NetworkConfiguratorDemo
RAM for global variables		 %
arduino:mbed_giga:giga N/A N/A N/A N/A
arduino:mbed_nano:nanorp2040connect N/A N/A N/A N/A
arduino:mbed_nicla:nicla_vision N/A N/A N/A N/A
arduino:mbed_opta:opta N/A N/A N/A N/A
arduino:mbed_portenta:envie_m7 N/A N/A N/A N/A
arduino:renesas_portenta:portenta_c33 N/A N/A N/A N/A
arduino:renesas_uno:unor4wifi N/A N/A N/A N/A
arduino:samd:mkrwifi1010 N/A N/A N/A N/A
arduino:samd:nano_33_iot N/A N/A N/A N/A
Click for full report CSV 
Board,examples/NetworkConfiguratorDemo<br>flash,%,examples/NetworkConfiguratorDemo<br>RAM for global variables,%
arduino:mbed_giga:giga,N/A,N/A,N/A,N/A
arduino:mbed_nano:nanorp2040connect,N/A,N/A,N/A,N/A
arduino:mbed_nicla:nicla_vision,N/A,N/A,N/A,N/A
arduino:mbed_opta:opta,N/A,N/A,N/A,N/A
arduino:mbed_portenta:envie_m7,N/A,N/A,N/A,N/A
arduino:renesas_portenta:portenta_c33,N/A,N/A,N/A,N/A
arduino:renesas_uno:unor4wifi,N/A,N/A,N/A,N/A
arduino:samd:mkrwifi1010,N/A,N/A,N/A,N/A
arduino:samd:nano_33_iot,N/A,N/A,N/A,N/A

@fabik111 fabik111 force-pushed the prepare-for-release branch from 5a27b1a to 2c1fd9c Compare May 12, 2025 13:38
@fabik111 fabik111 merged commit 06485dd into main May 12, 2025
41 of 45 checks passed
@fabik111 fabik111 deleted the prepare-for-release branch May 12, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@pennam pennam Awaiting requested review from pennam

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fabik111