"using namespace" should not be in in header File

this can give problems that can not be worked around by the code that is using the library
removed from SD.h and added to file.cpp and examples

Author: Woutvstk

examples/Datalogger/Datalogger.ino

@@ -26,6 +26,8 @@
 #include <SPI.h>
 #include <SD.h>
 
+using namespace SDLib;
+
 const int chipSelect = 10;
 
 void setup() {

examples/DumpFile/DumpFile.ino

@@ -25,6 +25,8 @@
 
 const int chipSelect = 10;
 
+using namespace SDLib;
+
 void setup() {
   // Open serial communications and wait for port to open:
   Serial.begin(9600);

examples/Files/Files.ino

@@ -21,6 +21,8 @@
 */
 #include <SD.h>
 
+using namespace SDLib;
+
 const int chipSelect = 10;
 File myFile;
 

examples/NonBlockingWrite/NonBlockingWrite.ino

@@ -33,6 +33,8 @@
 */
 #include <SD.h>
 
+using namespace SDLib;
+
 const int chipSelect = 10;
 
 // file name to use for writing

examples/ReadWrite/ReadWrite.ino

@@ -20,6 +20,8 @@
 */
 #include <SD.h>
 
+using namespace SDLib;
+
 const int chipSelect = 10;
 File myFile;
 

examples/listfiles/listfiles.ino

@@ -28,6 +28,8 @@
 */
 #include <SD.h>
 
+using namespace SDLib;
+
 const int chipSelect = 10;
 File root;
 

src/File.cpp

@@ -18,6 +18,8 @@
    uint8_t nfilecount=0;
 */
 
+using namespace SDLib;
+
 File::File(SdFile f, const char *n) {
   // oh man you are kidding me, new() doesn't exist? Ok we do it by hand!
   _file = (SdFile *)malloc(sizeof(SdFile));

src/SD.h

@@ -126,8 +126,6 @@ namespace SDLib {
 // We enclose File and SD classes in namespace SDLib to avoid conflicts
 // with others legacy libraries that redefines File class.
 
-// This ensure compatibility with sketches that uses only SD library
-using namespace SDLib;
 
 // This allows sketches to use SDLib::File with other libraries (in the
 // sketch you must use SDFile instead of File to disambiguate)