Unused password in "WiFiUdpSendReceiveString" example

[kajnorman]

WiFi/examples/WiFiUdpSendReceiveString/WiFiUdpSendReceiveString.ino

Line 56 in e9a3970

status = WiFi.begin(ssid);

should be:

status = WiFi.begin(ssid, pass);

Although the code is valid for an open access point, the presence of this line in the sketch clearly indicates the sketch was intended for use with a WPA encrypted access point:

WiFi/examples/WiFiUdpSendReceiveString/WiFiUdpSendReceiveString.ino

Line 22 in e9a3970

char pass[] = "secretPassword"; // your network password (use for WPA, or use as key for WEP)

The user will be confused to find the board is unable to connect to the access point even though they set the correct password.

[kajnorman]

Ahh! I see. It is not an error.. not even a minor error ;-) .

[per1234]

Hi @kajnorman. Thanks for your report. Even though the code is valid, I still think this should be considered a bug so I will reopen it.

Unused code is always a bug and in this case it is especially harmful because the user will be led to believe they can set the password via the pass variable, when that variable is actually not serving any purpose at all.

So the resolution should be either:

• Remove the unused pass variable declaration.
• Pass the pass variable to the WiFi.begin call.

A pull request for either of those fixes would be welcome.

[kajnorman]

Thx per1234 I totally agree with you. Thx for the nice library And thx for fixin the “issue”