Change Compiler.pathToSketch from String to File

Keeping filenames as File objects for as long as possible is generally a
good idea and this removes a dependency on `Sketch.getMainFilePath()`,
so it can be removed later.

Author: matthijskooijman

app/src/processing/app/SketchController.java

@@ -840,7 +840,7 @@ private String build(String buildPath, boolean verbose, boolean save) throws Run
     CompilerProgressListener progressListener = editor.status::progressUpdate;
 
     boolean deleteTemp = false;
-    String pathToSketch = sketch.getMainFilePath();
+    File pathToSketch = sketch.getPrimaryFile().getFile();
     if (sketch.isModified()) {
       // If any files are modified, make a copy of the sketch with the changes
       // saved, so arduino-builder will see the modifications.
@@ -853,19 +853,19 @@ private String build(String buildPath, boolean verbose, boolean save) throws Run
     } finally {
       // Make sure we clean up any temporary sketch copy
       if (deleteTemp)
-        FileUtils.recursiveDelete(new File(pathToSketch).getParentFile());
+        FileUtils.recursiveDelete(pathToSketch.getParentFile());
     }
   }
 
-  private String saveSketchInTempFolder() throws IOException {
+  private File saveSketchInTempFolder() throws IOException {
     File tempFolder = FileUtils.createTempFolder("arduino_modified_sketch_");
     FileUtils.copy(sketch.getFolder(), tempFolder);
 
     for (SketchFile file : Stream.of(sketch.getFiles()).filter(SketchFile::isModified).collect(Collectors.toList())) {
       Files.write(Paths.get(tempFolder.getAbsolutePath(), file.getFileName()), file.getProgram().getBytes());
     }
 
-    return Paths.get(tempFolder.getAbsolutePath(), sketch.getPrimaryFile().getFileName()).toString();
+    return Paths.get(tempFolder.getAbsolutePath(), sketch.getPrimaryFile().getFileName()).toFile();
   }
 
   protected boolean exportApplet(boolean usingProgrammer) throws Exception {

arduino-core/src/cc/arduino/Compiler.java

@@ -108,17 +108,17 @@ enum BuilderAction {
 
   private static final Pattern ERROR_FORMAT = Pattern.compile("(.+\\.\\w+):(\\d+)(:\\d+)*:\\s*error:\\s*(.*)\\s*", Pattern.MULTILINE | Pattern.DOTALL);
 
-  private final String pathToSketch;
+  private final File pathToSketch;
   private final Sketch sketch;
   private final String buildPath;
   private final boolean verbose;
   private RunnerException exception;
 
   public Compiler(Sketch data, String buildPath) {
-    this(data.getMainFilePath(), data, buildPath);
+    this(data.getPrimaryFile().getFile(), data, buildPath);
   }
 
-  public Compiler(String pathToSketch, Sketch sketch, String buildPath) {
+  public Compiler(File pathToSketch, Sketch sketch, String buildPath) {
     this.pathToSketch = pathToSketch;
     this.sketch = sketch;
     this.buildPath = buildPath;
@@ -241,7 +241,7 @@ private void callArduinoBuilder(TargetBoard board, TargetPlatform platform, Targ
       commandLine.addArgument("-verbose", false);
     }
 
-    commandLine.addArgument("\"" + pathToSketch + "\"", false);
+    commandLine.addArgument("\"" + pathToSketch.getAbsolutePath() + "\"", false);
 
     if (verbose) {
       System.out.println(commandLine);