SerialMonitor: added "no line ending" alert

Author: Federico Fissore

app/src/processing/app/AbstractMonitor.java

@@ -16,6 +16,7 @@
 
 public abstract class AbstractMonitor extends JFrame implements MessageConsumer {
 
+  protected final JLabel noLineEndingAlert;
   protected JTextArea textArea;
   protected JScrollPane scrollPane;
   protected JTextField textField;
@@ -69,29 +70,33 @@ public void actionPerformed(ActionEvent event) {
 
     getContentPane().add(scrollPane, BorderLayout.CENTER);
 
-    JPanel pane = new JPanel();
-    pane.setLayout(new BoxLayout(pane, BoxLayout.X_AXIS));
-    pane.setBorder(new EmptyBorder(4, 4, 4, 4));
+    JPanel upperPane = new JPanel();
+    upperPane.setLayout(new BoxLayout(upperPane, BoxLayout.X_AXIS));
+    upperPane.setBorder(new EmptyBorder(4, 4, 4, 4));
 
     textField = new JTextField(40);
     sendButton = new JButton(_("Send"));
 
-    pane.add(textField);
-    pane.add(Box.createRigidArea(new Dimension(4, 0)));
-    pane.add(sendButton);
+    upperPane.add(textField);
+    upperPane.add(Box.createRigidArea(new Dimension(4, 0)));
+    upperPane.add(sendButton);
 
-    getContentPane().add(pane, BorderLayout.NORTH);
+    getContentPane().add(upperPane, BorderLayout.NORTH);
 
-    pane = new JPanel();
+    final JPanel pane = new JPanel();
     pane.setLayout(new BoxLayout(pane, BoxLayout.X_AXIS));
     pane.setBorder(new EmptyBorder(4, 4, 4, 4));
 
     autoscrollBox = new JCheckBox(_("Autoscroll"), true);
 
+    noLineEndingAlert = new JLabel(I18n.format(_("You've pressed {0} but nothing was sent. Should you select a line ending?"), _("Send")));
+    noLineEndingAlert.setForeground(pane.getBackground());
+
     lineEndings = new JComboBox(new String[]{_("No line ending"), _("Newline"), _("Carriage return"), _("Both NL & CR")});
     lineEndings.addActionListener(new ActionListener() {
       public void actionPerformed(ActionEvent event) {
         Preferences.setInteger("serial.line_ending", lineEndings.getSelectedIndex());
+        noLineEndingAlert.setForeground(pane.getBackground());
       }
     });
     if (Preferences.get("serial.line_ending") != null) {
@@ -113,6 +118,8 @@ public void actionPerformed(ActionEvent event) {
 
     pane.add(autoscrollBox);
     pane.add(Box.createHorizontalGlue());
+    pane.add(noLineEndingAlert);
+    pane.add(Box.createRigidArea(new Dimension(8, 0)));
     pane.add(lineEndings);
     pane.add(Box.createRigidArea(new Dimension(8, 0)));
     pane.add(serialRates);

app/src/processing/app/SerialMonitor.java

@@ -20,6 +20,7 @@
 
 import processing.core.PApplet;
 
+import java.awt.*;
 import java.awt.event.ActionEvent;
 import java.awt.event.ActionListener;
 
@@ -77,6 +78,10 @@ private void send(String s) {
           s += "\r\n";
           break;
       }
+      if ("".equals(s) && lineEndings.getSelectedIndex() == 0 && !Preferences.has("runtime.line.ending.alert.notified")) {
+        noLineEndingAlert.setForeground(Color.RED);
+        Preferences.set("runtime.line.ending.alert.notified", "true");
+      }
       serial.write(s);
     }
   }