Zeroconf services may have multiple IP addresses: let's consider them all

Author: Federico Fissore

app/src/cc/arduino/packages/discoverers/NetworkDiscovery.java

@@ -33,7 +33,8 @@ public List<BoardPort> discovery() {
     Iterator<BoardPort> iterator = ports.iterator();
     while (iterator.hasNext()) {
       try {
-        if (!NetUtils.isReachable(InetAddress.getByName(iterator.next().getAddress()))) {
+        BoardPort board = iterator.next();
+        if (!NetUtils.isReachable(InetAddress.getByName(board.getAddress()), Integer.parseInt(board.getPrefs().get("port")))) {
           iterator.remove();
         }
       } catch (UnknownHostException e) {
@@ -93,34 +94,38 @@ public void serviceRemoved(ServiceEvent serviceEvent) {
   @Override
   public void serviceResolved(ServiceEvent serviceEvent) {
     ServiceInfo info = serviceEvent.getInfo();
-    String address = info.getInet4Addresses()[0].getHostAddress();
-    String name = serviceEvent.getName();
+    for (InetAddress inetAddress : info.getInet4Addresses()) {
+      String address = inetAddress.getHostAddress();
+      String name = serviceEvent.getName();
+
+      PreferencesMap prefs = null;
+      String board = null;
+      if (info.hasData()) {
+        prefs = new PreferencesMap();
+        board = info.getPropertyString("board");
+        prefs.put("board", board);
+        prefs.put("distro_version", info.getPropertyString("distro_version"));
+      }
 
-    PreferencesMap prefs = null;
-    String board = null;
-    if (info.hasData()) {
-      prefs = new PreferencesMap();
-      board = info.getPropertyString("board");
-      prefs.put("board", board);
-      prefs.put("distro_version", info.getPropertyString("distro_version"));
-    }
+      prefs.put("port", "" + info.getPort());
 
-    String label = name + " at " + address;
-    if (board != null) {
-      String boardName = Base.getPlatform().resolveDeviceByBoardID(Base.packages, board);
-      label += " (" + boardName + ")";
-    }
+      String label = name + " at " + address;
+      if (board != null) {
+        String boardName = Base.getPlatform().resolveDeviceByBoardID(Base.packages, board);
+        label += " (" + boardName + ")";
+      }
 
-    BoardPort port = new BoardPort();
-    port.setAddress(address);
-    port.setBoardName(name);
-    port.setProtocol("network");
-    port.setPrefs(prefs);
-    port.setLabel(label);
+      BoardPort port = new BoardPort();
+      port.setAddress(address);
+      port.setBoardName(name);
+      port.setProtocol("network");
+      port.setPrefs(prefs);
+      port.setLabel(label);
 
-    synchronized (this) {
-      removeDuplicateBoards(port);
-      ports.add(port);
+      synchronized (this) {
+        removeDuplicateBoards(port);
+        ports.add(port);
+      }
     }
   }
 

app/src/processing/app/helpers/NetUtils.java

@@ -7,11 +7,11 @@
 
 public abstract class NetUtils {
 
-  public static boolean isReachable(InetAddress address) {
+  public static boolean isReachable(InetAddress address, int port) {
     Socket socket = null;
     try {
       socket = new Socket();
-      socket.connect(new InetSocketAddress(address, 80), 100);
+      socket.connect(new InetSocketAddress(address, port), 100);
       return true;
     } catch (IOException e) {
       return false;