Move isModified() from SketchController to Sketch

Also, update any code that uses it, removing the dependency on
SketchController entirely if possible.

Author: matthijskooijman

app/src/processing/app/Base.java

@@ -570,7 +570,7 @@ protected void storeSketches() {
       String path = editor.getSketch().getMainFilePath();
       // In case of a crash, save untitled sketches if they contain changes.
       // (Added this for release 0158, may not be a good idea.)
-      if (path.startsWith(untitledPath) && !editor.getSketchController().isModified()) {
+      if (path.startsWith(untitledPath) && !editor.getSketch().isModified()) {
         continue;
       }
       PreferencesData.set("last.sketch" + index + ".path", path);

app/src/processing/app/Editor.java

@@ -84,11 +84,17 @@ public class Editor extends JFrame implements RunnerListener {
   private ArrayList<EditorTab> tabs = new ArrayList<>();
   private int currentTabIndex = -1;
 
-  private static class ShouldSaveIfModified implements Predicate<SketchController> {
+  private static class ShouldSaveIfModified
+      implements Predicate<SketchController> {
 
     @Override
-    public boolean test(SketchController sketch) {
-      return PreferencesData.getBoolean("editor.save_on_verify") && sketch.isModified() && !sketch.isReadOnly(BaseNoGui.librariesIndexer.getInstalledLibraries(), BaseNoGui.getExamplesPath());
+    public boolean test(SketchController controller) {
+      return PreferencesData.getBoolean("editor.save_on_verify")
+             && controller.getSketch().isModified()
+             && !controller.isReadOnly(
+                                       BaseNoGui.librariesIndexer
+                                           .getInstalledLibraries(),
+                                       BaseNoGui.getExamplesPath());
     }
   }
 
@@ -1846,7 +1852,8 @@ public void internalCloseRunner() {
    * @return false if canceling the close/quit operation
    */
   protected boolean checkModified() {
-    if (!sketchController.isModified()) return true;
+    if (!sketch.isModified())
+      return true;
 
     // As of Processing 1.0.10, this always happens immediately.
     // http://dev.processing.org/bugs/show_bug.cgi?id=1456
@@ -2177,7 +2184,11 @@ private boolean serialPrompt() {
    */
   synchronized public void handleExport(final boolean usingProgrammer) {
     if (PreferencesData.getBoolean("editor.save_on_verify")) {
-      if (sketchController.isModified() && !sketchController.isReadOnly(BaseNoGui.librariesIndexer.getInstalledLibraries(), BaseNoGui.getExamplesPath())) {
+      if (sketch.isModified()
+          && !sketchController.isReadOnly(
+                                          BaseNoGui.librariesIndexer
+                                              .getInstalledLibraries(),
+                                          BaseNoGui.getExamplesPath())) {
         handleSave(true);
       }
     }

app/src/processing/app/SketchController.java

@@ -457,21 +457,13 @@ public void calcModified() {
 
     if (OSUtils.isMacOS()) {
       // http://developer.apple.com/qa/qa2001/qa1146.html
-      Object modifiedParam = isModified() ? Boolean.TRUE : Boolean.FALSE;
+      Object modifiedParam = sketch.isModified() ? Boolean.TRUE : Boolean.FALSE;
       editor.getRootPane().putClientProperty("windowModified", modifiedParam);
       editor.getRootPane().putClientProperty("Window.documentModified", modifiedParam);
     }
   }
 
 
-  public boolean isModified() {
-    for (SketchCode code : sketch.getCodes()) {
-      if (code.isModified())
-        return true;
-    }
-    return false;
-  }
-
 
   /**
    * Save all code in the current sketch.
@@ -897,7 +889,7 @@ private String build(String buildPath, boolean verbose, boolean save) throws Run
 
     boolean deleteTemp = false;
     String pathToSketch = sketch.getMainFilePath();
-    if (isModified()) {
+    if (sketch.isModified()) {
       // If any files are modified, make a copy of the sketch with the changes
       // saved, so arduino-builder will see the modifications.
       pathToSketch = saveSketchInTempFolder();

app/src/processing/app/tools/FixEncoding.java

@@ -49,7 +49,7 @@ public void init(Editor editor) {
 
 
   public void run() {
-    SketchController sketch = editor.getSketchController();
+    Sketch sketch = editor.getSketch();
     //SketchCode code = sketch.current;
 
     if (sketch.isModified()) {
@@ -65,8 +65,8 @@ public void run() {
       }
     }
     try {
-      for (int i = 0; i < sketch.getSketch().getCodeCount(); i++) {
-        SketchCode code = sketch.getSketch().getCode(i);
+      for (int i = 0; i < sketch.getCodeCount(); i++) {
+        SketchCode code = sketch.getCode(i);
         editor.findTab(code).setText(loadWithLocalEncoding(code.getFile()));
       }
     } catch (IOException e) {

arduino-core/src/processing/app/Sketch.java

@@ -214,4 +214,15 @@ public File getFolder() {
   public File getDataFolder() {
     return dataFolder;
   }
+
+  /**
+   * Is any of the files in this sketch modified?
+   */
+  public boolean isModified() {
+    for (SketchCode code : codes) {
+      if (code.isModified())
+        return true;
+    }
+    return false;
+  }
 }