Skip to content

Commit ba7fb55

Browse files
committed
Fixed buffer overflow on String class (Paul Stoffregen)
1 parent f80c6c5 commit ba7fb55

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

hardware/arduino/avr/cores/arduino/WString.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -296,14 +296,14 @@ unsigned char String::concat(unsigned char num)
296296

297297
unsigned char String::concat(int num)
298298
{
299-
char buf[7];
299+
char buf[12];
300300
itoa(num, buf, 10);
301301
return concat(buf, strlen(buf));
302302
}
303303

304304
unsigned char String::concat(unsigned int num)
305305
{
306-
char buf[6];
306+
char buf[11];
307307
utoa(num, buf, 10);
308308
return concat(buf, strlen(buf));
309309
}

hardware/arduino/avr/cores/robot/WString.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -296,14 +296,14 @@ unsigned char String::concat(unsigned char num)
296296

297297
unsigned char String::concat(int num)
298298
{
299-
char buf[7];
299+
char buf[12];
300300
itoa(num, buf, 10);
301301
return concat(buf, strlen(buf));
302302
}
303303

304304
unsigned char String::concat(unsigned int num)
305305
{
306-
char buf[6];
306+
char buf[11];
307307
utoa(num, buf, 10);
308308
return concat(buf, strlen(buf));
309309
}

hardware/arduino/sam/cores/arduino/WString.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -297,14 +297,14 @@ unsigned char String::concat(unsigned char num)
297297

298298
unsigned char String::concat(int num)
299299
{
300-
char buf[7];
300+
char buf[12];
301301
itoa(num, buf, 10);
302302
return concat(buf, strlen(buf));
303303
}
304304

305305
unsigned char String::concat(unsigned int num)
306306
{
307-
char buf[6];
307+
char buf[11];
308308
utoa(num, buf, 10);
309309
return concat(buf, strlen(buf));
310310
}

0 commit comments

Comments
 (0)