New editor: setForeground doesn't change default text color, "IDENTIFIER" token style does the job. Fixes #3372

Author: Federico Fissore

app/src/processing/app/syntax/SketchTextArea.java

@@ -106,7 +106,6 @@ private void setTheme(String name) throws IOException {
       IOUtils.closeQuietly(defaultXmlInputStream);
     }
 
-    setForeground(processing.app.Theme.getColor("editor.fgcolor"));
     setBackground(processing.app.Theme.getColor("editor.bgcolor"));
     setCurrentLineHighlightColor(processing.app.Theme.getColor("editor.linehighlight.color"));
     setCaretColor(processing.app.Theme.getColor("editor.caret.color"));
@@ -129,6 +128,10 @@ private void setTheme(String name) throws IOException {
     setSyntaxTheme(TokenTypes.LITERAL_BOOLEAN, "literal_boolean");
     setSyntaxTheme(TokenTypes.LITERAL_CHAR, "literal_char");
     setSyntaxTheme(TokenTypes.LITERAL_STRING_DOUBLE_QUOTE, "literal_string_double_quote");
+
+    Style style = getSyntaxScheme().getStyle(TokenTypes.IDENTIFIER);
+    style.foreground = processing.app.Theme.getColor("editor.fgcolor");
+    getSyntaxScheme().setStyle(TokenTypes.IDENTIFIER, style);
   }
 
   private void setSyntaxTheme(int tokenType, String id) {
@@ -391,7 +394,7 @@ public void mouseMoved(MouseEvent e) {
         // Copy token, viewToModel() unfortunately modifies Token
         t = new TokenImpl(t);
       }
-      Cursor c2 = null;
+      Cursor c2;
       if (t != null && t.isHyperlink()) {
         if (hoveredOverLinkOffset == -1 ||
           hoveredOverLinkOffset != t.getOffset()) {