Removed a lot of useless equals overrides.

Those introduces a very convoluted logic that is needed only in
two cases. Moreover those are better handled by directly checking
the object.

Author: cmaglie

app/src/cc/arduino/contributions/libraries/filters/CategoryPredicate.java

@@ -46,9 +46,4 @@ public boolean test(ContributedLibrary input) {
     return input.getCategory() != null && category.equals(input.getCategory());
   }
 
-  @Override
-  public boolean equals(Object obj) {
-    return obj instanceof CategoryPredicate && ((CategoryPredicate) obj).category.equals(category);
-  }
-
 }

app/src/cc/arduino/contributions/libraries/filters/InstalledLibraryPredicate.java

@@ -51,9 +51,4 @@ public boolean test(ContributedLibrary input) {
       .count() > 0;
   }
 
-  @Override
-  public boolean equals(Object obj) {
-    return obj instanceof InstalledLibraryPredicate;
-  }
-
 }

app/src/cc/arduino/contributions/libraries/filters/OnlyUpstreamReleasePredicate.java

@@ -41,8 +41,4 @@ public boolean test(ContributedLibrary input) {
     return !(input instanceof UserLibrary);
   }
 
-  @Override
-  public boolean equals(Object obj) {
-    return obj instanceof OnlyUpstreamReleasePredicate;
-  }
 }

app/src/cc/arduino/contributions/libraries/ui/DropdownInstalledLibraryItem.java

@@ -48,9 +48,4 @@ public Predicate<ContributedLibrary> getFilterPredicate() {
     return new InstalledLibraryPredicate();
   }
 
-  @Override
-  public boolean equals(Object obj) {
-    return obj instanceof DropdownInstalledLibraryItem;
-  }
-
 }

app/src/cc/arduino/contributions/libraries/ui/DropdownLibraryOfCategoryItem.java

@@ -54,9 +54,4 @@ public Predicate<ContributedLibrary> getFilterPredicate() {
     return new CategoryPredicate(category);
   }
 
-  @Override
-  public boolean equals(Object obj) {
-    return obj instanceof DropdownLibraryOfCategoryItem && ((DropdownLibraryOfCategoryItem) obj).category.equals(category);
-  }
-
 }

app/src/cc/arduino/contributions/libraries/ui/DropdownLibraryOfTypeItem.java

@@ -54,9 +54,4 @@ public Predicate<ContributedLibrary> getFilterPredicate() {
     return new TypePredicate(type);
   }
 
-  @Override
-  public boolean equals(Object obj) {
-    return obj instanceof DropdownLibraryOfTypeItem && ((DropdownLibraryOfTypeItem) obj).type.equals(type);
-  }
-
 }

app/src/cc/arduino/contributions/libraries/ui/DropdownUpdatableLibrariesItem.java

@@ -49,9 +49,4 @@ public String toString() {
     return tr("Updatable");
   }
 
-  @Override
-  public boolean equals(Object obj) {
-    return obj instanceof DropdownUpdatableLibrariesItem;
-  }
-
 }

app/src/cc/arduino/contributions/libraries/ui/LibraryManagerUI.java

@@ -118,7 +118,7 @@ public LibraryManagerUI(Frame parent, LibraryInstaller installer) {
     public void actionPerformed(ActionEvent event) {
       DropdownItem<ContributedLibrary> selected = (DropdownItem<ContributedLibrary>) typeChooser.getSelectedItem();
       previousRowAtPoint = -1;
-      if (typeFilter == null || !typeFilter.equals(selected)) {
+      if (typeFilter == null || typeFilter != selected.getFilterPredicate()) {
         typeFilter = selected.getFilterPredicate();
         if (contribTable.getCellEditor() != null) {
           contribTable.getCellEditor().stopCellEditing();
@@ -143,10 +143,10 @@ public void updateUI() {
     categoryChooser.removeActionListener(categoryChooserActionListener);
     typeChooser.removeActionListener(typeChooserActionListener);
 
-    categoryFilter = null;
-    categoryChooser.removeAllItems();
 
     // Load categories
+    categoryFilter = x -> true;
+    categoryChooser.removeAllItems();
     categoryChooser.addItem(new DropdownAllItem());
     Collection<String> categories = BaseNoGui.librariesIndexer.getIndex().getCategories();
     for (String category : categories) {
@@ -162,7 +162,7 @@ public void updateUI() {
       categoryChooser.setSelectedIndex(0);
     }
 
-    typeFilter = null;
+    typeFilter = x -> true;
     typeChooser.removeAllItems();
     typeChooser.addItem(new DropdownAllItem());
     typeChooser.addItem(new DropdownUpdatableLibrariesItem());

app/src/cc/arduino/contributions/packages/filters/CategoryPredicate.java

@@ -46,9 +46,4 @@ public boolean test(ContributedPlatform input) {
     return input.getCategory() != null && category.equals(input.getCategory());
   }
 
-  @Override
-  public boolean equals(Object obj) {
-    return obj instanceof CategoryPredicate && ((CategoryPredicate) obj).category.equals(category);
-  }
-
 }

app/src/cc/arduino/contributions/packages/ui/ContributionManagerUI.java

@@ -98,14 +98,13 @@ public void updateUI() {
 
     categoryChooser.removeActionListener(categoryChooserActionListener);
 
-    categoryFilter = null;
-    categoryChooser.removeAllItems();
-
     filterField.setEnabled(getContribModel().getRowCount() > 0);
 
     categoryChooser.addActionListener(categoryChooserActionListener);
 
     // Enable categories combo only if there are two or more choices
+    categoryFilter = x -> true;
+    categoryChooser.removeAllItems();
     categoryChooser.addItem(new DropdownAllCoresItem());
     categoryChooser.addItem(new DropdownUpdatableCoresItem());
     Collection<String> categories = BaseNoGui.indexer.getCategories();