Skip to content

Commit 253f211

Browse files
committed
Fix MKRNB name and module init
1 parent fc95e90 commit 253f211

File tree

3 files changed

+36
-31
lines changed

3 files changed

+36
-31
lines changed

boards.txt

Lines changed: 25 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -222,32 +222,32 @@ mkrgsm1400.bootloader.file=mkrgsm1400/samd21_sam_ba_arduino_mkrgsm1400.bin
222222

223223
# Arduino MKR NB-IoT 1450
224224
# --------------------
225-
mkrgsm1400.name=Arduino MKR NB-IoT 1450
226-
mkrgsm1400.vid.0=0x2341
227-
mkrgsm1400.pid.0=0x8054
228-
mkrgsm1400.vid.1=0x2341
229-
mkrgsm1400.pid.1=0x0054
225+
mkrnb1500.name=Arduino MKR NB 1500
226+
mkrnb1500.vid.0=0x2341
227+
mkrnb1500.pid.0=0x8055
228+
mkrnb1500.vid.1=0x2341
229+
mkrnb1500.pid.1=0x0055
230230

231-
mkrgsm1400.upload.tool=bossac
232-
mkrgsm1400.upload.protocol=sam-ba
233-
mkrgsm1400.upload.maximum_size=262144
234-
mkrgsm1400.upload.use_1200bps_touch=true
235-
mkrgsm1400.upload.wait_for_upload_port=true
236-
mkrgsm1400.upload.native_usb=true
237-
mkrgsm1400.build.mcu=cortex-m0plus
238-
mkrgsm1400.build.f_cpu=48000000L
239-
mkrgsm1400.build.usb_product="Arduino MKR NB-IoT 1450"
240-
mkrgsm1400.build.usb_manufacturer="Arduino LLC"
241-
mkrgsm1400.build.board=SAMD_MKRGSM1400
242-
mkrgsm1400.build.core=arduino
243-
mkrgsm1400.build.extra_flags=-D__SAMD21G18A__ {build.usb_flags} -DUSE_BQ24195L_PMIC -DNO_HW_FLOW_CONTROL
244-
mkrgsm1400.build.ldscript=linker_scripts/gcc/flash_with_bootloader.ld
245-
mkrgsm1400.build.openocdscript=openocd_scripts/arduino_zero.cfg
246-
mkrgsm1400.build.variant=mkrgsm1400
247-
mkrgsm1400.build.vid=0x2341
248-
mkrgsm1400.build.pid=0x8054
249-
mkrgsm1400.bootloader.tool=openocd
250-
mkrgsm1400.bootloader.file=mkrgsm1400/samd21_sam_ba_arduino_mkrgsm1400.bin
231+
mkrnb1500.upload.tool=bossac
232+
mkrnb1500.upload.protocol=sam-ba
233+
mkrnb1500.upload.maximum_size=262144
234+
mkrnb1500.upload.use_1200bps_touch=true
235+
mkrnb1500.upload.wait_for_upload_port=true
236+
mkrnb1500.upload.native_usb=true
237+
mkrnb1500.build.mcu=cortex-m0plus
238+
mkrnb1500.build.f_cpu=48000000L
239+
mkrnb1500.build.usb_product="Arduino MKR NB 1500"
240+
mkrnb1500.build.usb_manufacturer="Arduino LLC"
241+
mkrnb1500.build.board=SAMD_MKRNBIOT1450
242+
mkrnb1500.build.core=arduino
243+
mkrnb1500.build.extra_flags=-D__SAMD21G18A__ {build.usb_flags} -DUSE_BQ24195L_PMIC -DNO_HW_FLOW_CONTROL
244+
mkrnb1500.build.ldscript=linker_scripts/gcc/flash_with_bootloader.ld
245+
mkrnb1500.build.openocdscript=openocd_scripts/arduino_zero.cfg
246+
mkrnb1500.build.variant=mkrgsm1400
247+
mkrnb1500.build.vid=0x2341
248+
mkrnb1500.build.pid=0x8055
249+
mkrnb1500.bootloader.tool=openocd
250+
mkrnb1500.bootloader.file=mkrnbiot1500/samd21_sam_ba_arduino_mkrnbiot1500.bin
251251

252252
# Arduino MKR WAN 1300
253253
# --------------------

variants/mkrgsm1400/variant.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -230,14 +230,14 @@ void initVariant() {
230230
pinMode(GSM_RESETN, OUTPUT);
231231
digitalWrite(GSM_RESETN, HIGH);
232232

233-
// set GSM DTR to LOW on start
234-
pinMode(GSM_DTR, OUTPUT);
235-
digitalWrite(GSM_DTR, LOW);
233+
pinMode(PIN_SERIAL2_DTR, OUTPUT);
236234

237235
#ifdef NO_HW_FLOW_CONTROL
238-
// set GSM DTR to LOW on start
239-
pinMode(PIN_SERIAL2_RTS, OUTPUT);
240-
digitalWrite(PIN_SERIAL2_RTS, LOW);
236+
// set PWR pin to HIGH on NB-IoT
237+
digitalWrite(PIN_SERIAL2_DTR, HIGH);
238+
#else
239+
// set GSM DTR to LOW on start
240+
digitalWrite(PIN_SERIAL2_DTR, LOW);
241241
#endif
242242
}
243243

variants/mkrgsm1400/variant.h

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,12 @@
6767
#define GSM_RTS (28u)
6868
#define GSM_CTS (29u)
6969
#define GSM_RESETN (31u)
70+
71+
#ifndef NO_HW_FLOW_CONTROL
7072
#define GSM_DTR (35u)
73+
#else
74+
#define GSM_DTR (-1)
75+
#endif
7176

7277
// LEDs
7378
// ----

0 commit comments

Comments
 (0)