Skip to content

Commit d8c0e88

Browse files
committed
format-check: add collect errors job
The Github UI for required checks does not integrate with the workflows described in the .github directory. Currently jobs that are never started due to conditional execution are not even reported, so the UI shows "expected" and locks up merges. Collect format errors so that the Github UI can be happy to track one job that is always executed. This job will fail if any of the format-check jobs failed or were cancelled, and will be ignored (but reported) otherwise. Signed-off-by: Luca Burelli <[email protected]>
1 parent a26551e commit d8c0e88

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

.github/workflows/format_check.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,3 +58,13 @@ jobs:
5858
clang-format-version: '19'
5959
check-path: ${{ matrix.path['check'] }}
6060
exclude-regex: ${{ matrix.path['exclude'] }}
61+
62+
verify-format:
63+
name: Collect job errors
64+
runs-on: ubuntu-latest
65+
if: cancelled() || contains(needs.*.result, 'failure')
66+
needs:
67+
- format-check
68+
steps:
69+
- name: Notify failure
70+
run: exit 1

0 commit comments

Comments
 (0)