Skip to content

Commit fa387b6

Browse files
committed
github: fix verify jobs to always report status
Fix verify-core and verify-format jobs that were causing GitHub PR status checks to get stuck with "Waiting for status to be reported". Both jobs now use 'if: always()' to ensure they run and report status regardless of dependency job outcomes. Signed-off-by: iabdalkader <[email protected]>
1 parent acbf570 commit fa387b6

File tree

2 files changed

+24
-3
lines changed

2 files changed

+24
-3
lines changed

.github/workflows/format_check.yml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,3 +58,18 @@ jobs:
5858
clang-format-version: '19'
5959
check-path: ${{ matrix.path['check'] }}
6060
exclude-regex: ${{ matrix.path['exclude'] }}
61+
62+
verify-format:
63+
name: Verify format status
64+
runs-on: ubuntu-latest
65+
if: always()
66+
needs: format-check
67+
steps:
68+
- name: Check format results
69+
run: |
70+
if [[ "${{ needs.format-check.result }}" == "failure" || "${{ needs.format-check.result }}" == "cancelled" ]]; then
71+
echo "Format check failed or was cancelled"
72+
exit 1
73+
else
74+
echo "Format check completed successfully"
75+
fi

.github/workflows/package_core.yml

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -186,13 +186,19 @@ jobs:
186186
verify-core:
187187
name: Collect job errors
188188
runs-on: ubuntu-latest
189-
if: cancelled() || contains(needs.*.result, 'failure')
189+
if: always()
190190
needs:
191191
- package-core
192192
- test-core
193193
steps:
194-
- name: Notify failure
195-
run: exit 1
194+
- name: Check job results
195+
run: |
196+
if [[ "${{ needs.package-core.result }}" == "failure" || "${{ needs.test-core.result }}" == "failure" || "${{ needs.package-core.result }}" == "cancelled" || "${{ needs.test-core.result }}" == "cancelled" ]]; then
197+
echo "One or more required jobs failed or were cancelled"
198+
exit 1
199+
else
200+
echo "All required jobs completed successfully"
201+
fi
196202
197203
publish-core:
198204
name: Publish core

0 commit comments

Comments
 (0)