Fixed completion in profile lib remove

Author: cmaglie

internal/cli/arguments/completion.go

@@ -20,6 +20,7 @@ import (
 
 	"github.com/arduino/arduino-cli/internal/cli/instance"
 	rpc "github.com/arduino/arduino-cli/rpc/cc/arduino/cli/commands/v1"
+	"github.com/arduino/go-paths-helper"
 	"go.bug.st/f"
 )
 
@@ -172,3 +173,19 @@ func GetAvailablePorts(ctx context.Context, srv rpc.ArduinoCoreServiceServer) []
 	// Transform the data structure for the completion (DetectedPort -> Port)
 	return f.Map(list.GetPorts(), (*rpc.DetectedPort).GetPort)
 }
+
+// GetProfileLibraries is an helper function useful to autocomplete.
+// It returns a list of libraries present in the specified profile.
+func GetProfileLibraries(ctx context.Context, srv rpc.ArduinoCoreServiceServer, sketchPath *paths.Path, profile string) []string {
+	resp, err := srv.ProfileLibList(ctx, &rpc.ProfileLibListRequest{
+		SketchPath:  sketchPath.String(),
+		ProfileName: profile,
+	})
+	if err != nil {
+		return nil
+	}
+	res := f.Map(resp.GetLibraries(), func(lib *rpc.ProfileLibraryReference) string {
+		return lib.GetIndexLibrary().GetName()
+	})
+	return res
+}

internal/cli/profile/profile_lib_remove.go

@@ -46,7 +46,10 @@ func initLibRemoveCommand(srv rpc.ArduinoCoreServiceServer) *cobra.Command {
 			runLibRemoveCommand(cmd.Context(), srv, args, profileArg.Get(), destDir, noDeps)
 		},
 		ValidArgsFunction: func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
-			return arguments.GetInstallableLibs(cmd.Context(), srv), cobra.ShellCompDirectiveDefault
+			ctx := cmd.Context()
+			sketchPath := arguments.InitSketchPath(destDir)
+			completions := arguments.GetProfileLibraries(ctx, srv, sketchPath, profileArg.Get())
+			return completions, cobra.ShellCompDirectiveNoFileComp
 		},
 	}
 	profileArg.AddToCommand(removeCommand, srv)