Handle not found error in tools.instakll

Author: matteosuppo

design/pkgs.go

@@ -55,6 +55,10 @@ var _ = Service("tools", func() {
 	})
 
 	Method("install", func() {
+		Error("not_found", ErrorResult, "tool not found")
+		HTTP(func() {
+			Response("not_found", StatusBadRequest)
+		})
 		Payload(ToolPayload)
 		HTTP(func() {
 			PUT("/pkgs/tools/installed")

gen/tools/client.go

@@ -116,7 +116,9 @@ func (c *Tools) Install(ctx context.Context, payload *tools.ToolPayload) error {
 		}
 	}
 
-	return nil
+	return tools.MakeNotFound(
+		fmt.Errorf("tool not found with packager '%s', name '%s', version '%s'",
+			payload.Packager, payload.Name, payload.Version))
 }
 
 func (c *Tools) install(ctx context.Context, tool Tool) error {

gen/tools/service.go

@@ -6,6 +6,7 @@ import (
 	"io/ioutil"
 	"net/http"
 	"net/http/httptest"
+	"strings"
 	"testing"
 
 	"github.com/arduino/arduino-create-agent/gen/indexes"
@@ -56,6 +57,12 @@ func TestTools(t *testing.T) {
 		t.Fatalf("expected %d == %d (%s)", len(available), 61, "len(available)")
 	}
 
+	// Try to install a non-existent tool
+	err = service.Install(ctx, &tools.ToolPayload{})
+	if err == nil || !strings.Contains(err.Error(), "tool not found with packager '', name '', version ''") {
+		t.Fatalf("expected '%v' == '%v' (%s)", err, "tool not found with packager '', name '', version ''", "err")
+	}
+
 	// Install a tool
 	err = service.Install(ctx, &tools.ToolPayload{
 		Packager: "arduino",