Apply review suggestions

Author: MatteoPologruto

check_for_updates.go

@@ -24,55 +24,52 @@ import (
 	"github.com/fatih/color"
 	semver "go.bug.st/relaxed-semver"
 
-	"github.com/arduino/arduino-flasher-cli/feedback"
 	"github.com/arduino/arduino-flasher-cli/i18n"
 	"github.com/arduino/arduino-flasher-cli/updater"
 )
 
-type FlasherRelease struct {
-	TagName string `json:"tag_name"`
-}
-
-func checkForUpdates() error {
+func checkForUpdates() (string, error) {
 	currentVersion, err := semver.Parse(Version)
 	if err != nil {
-		return err
+		return "", err
 	}
 
 	c := updater.NewClient()
 	req, err := http.NewRequest("GET", "https://api.github.com/repos/arduino/arduino-flasher-cli/releases/latest", nil)
 	if err != nil {
-		return err
+		return "", err
 	}
 	resp, err := c.HTTPClient.Do(req)
 	if err != nil {
-		return err
+		return "", err
 	}
 	defer resp.Body.Close()
 
-	var release FlasherRelease
+	var release struct {
+		TagName string `json:"tag_name"`
+	}
+
 	err = json.NewDecoder(resp.Body).Decode(&release)
 	if err != nil {
-		return err
+		return "", err
 	}
 
 	release.TagName = strings.TrimPrefix(release.TagName, "v")
 	latestVersion, err := semver.Parse(release.TagName)
 	if err != nil {
-		return err
+		return "", err
 	}
 
 	// Do nothing if the Arduino Flasher CLI is up to date
 	if currentVersion.GreaterThanOrEqual(latestVersion) {
-		return nil
+		return "", nil
 	}
 
 	msg := fmt.Sprintf("\n\n%s %s → %s\n%s",
 		color.YellowString(i18n.Tr("A new release of Arduino Flasher CLI is available:")),
 		color.CyanString(currentVersion.String()),
 		color.CyanString(latestVersion.String()),
 		color.YellowString("https://www.arduino.cc/en/software/#flasher-tool"))
-	feedback.Print(msg)
 
-	return nil
+	return msg, nil
 }

download.go

@@ -56,8 +56,11 @@ func runDownloadCommand(args []string, destDir string) {
 		feedback.Fatal(i18n.Tr("error downloading the image: %v", err), feedback.ErrBadArgument)
 	}
 
-	err = checkForUpdates()
+	msg, err := checkForUpdates()
 	if err != nil {
 		feedback.Warning("\n\nfailed to check for updates: " + err.Error())
 	}
+	if msg != "" {
+		feedback.Print(msg)
+	}
 }

flash.go

@@ -97,8 +97,11 @@ func runFlashCommand(ctx context.Context, args []string, forceYes bool) {
 		feedback.Fatal(i18n.Tr("error flashing the board: %v", err), feedback.ErrBadArgument)
 	}
 
-	err = checkForUpdates()
+	msg, err := checkForUpdates()
 	if err != nil {
 		feedback.Warning("\n\nfailed to check for updates: " + err.Error())
 	}
+	if msg != "" {
+		feedback.Print(msg)
+	}
 }

list.go

@@ -46,10 +46,13 @@ func runListCommand() {
 	}
 
 	feedback.PrintResult(listResult{Latest: manifest.Latest, Releases: manifest.Releases})
-	err = checkForUpdates()
+	msg, err := checkForUpdates()
 	if err != nil {
 		feedback.Warning("\n\nfailed to check for updates: " + err.Error())
 	}
+	if msg != "" {
+		feedback.Print(msg)
+	}
 }
 
 type listResult struct {

main.go

@@ -60,10 +60,13 @@ func main() {
 			Short: "Print the version number of Arduino Flasher CLI",
 			Run: func(cmd *cobra.Command, args []string) {
 				feedback.Print("Arduino Flasher CLI " + Version)
-				err := checkForUpdates()
+				msg, err := checkForUpdates()
 				if err != nil {
 					feedback.Warning("\n\nfailed to check for updates: " + err.Error())
 				}
+				if msg != "" {
+					feedback.Print(msg)
+				}
 			},
 		})