Skip to content

Commit 6cb375a

Browse files
committed
Remove unnecessary conditional from example workflow snippet
Now that arduino/compile-sketches always generates a sketches report, the conditional in the workflow snippet in the readme is unnecessary. Although a user may decide they want to do advanced configuration of their workflow to control when the artifact is generated, there is no requirement that it only be made on pull_request events, so this only adds unnecessary complexity to the example. The example should contain only the minimum necessary to effectively demonstrate the basic use of the action.
1 parent 6b42c37 commit 6cb375a

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,8 +176,7 @@ Storing the sketches compilation report report as a [workflow artifact](https://
176176
- uses: arduino/compile-sketches@main
177177
with:
178178
enable-deltas-report: true
179-
- if: github.event_name == 'pull_request'
180-
uses: actions/upload-artifact@v1
179+
- uses: actions/upload-artifact@v1
181180
with:
182181
name: size-deltas-reports
183182
path: size-deltas-reports

0 commit comments

Comments
 (0)