Skip to content

Commit a6a5c92

Browse files
committed
Update sketches report key name to reflect expanded scope
The sketches report now contains data for all compiled sketches, rather than a single one. The "sketch" key was previously used for the sketch path, but it is now used to contain all the data for the individual sketches. The move to reporting data for all sketches already causes a breaking change to the report, so updating the key name does no additional harm.
1 parent ae583ed commit a6a5c92

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

compilesketches/compilesketches.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ class ReportKeys:
9292
delta = "delta"
9393
minimum = "minimum"
9494
maximum = "maximum"
95-
sketch = "sketch"
95+
sketches = "sketches"
9696

9797
dependency_name_key = "name"
9898
dependency_version_key = "version"
@@ -958,7 +958,7 @@ def get_sketches_report(self, sketch_report_list):
958958
+ os.environ["GITHUB_REPOSITORY"]
959959
+ "/commit/"
960960
+ current_git_ref),
961-
self.ReportKeys.sketch: sketch_report_list
961+
self.ReportKeys.sketches: sketch_report_list
962962
}
963963

964964
sizes_summary_report = self.get_sizes_summary_report(sketch_report_list=sketch_report_list)

compilesketches/tests/test_compilesketches.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1521,7 +1521,7 @@ def test_get_sketches_report(monkeypatch, mocker):
15211521
+ "/commit/"
15221522
+ current_git_ref),
15231523
compilesketches.CompileSketches.ReportKeys.sizes: sizes_summary_report,
1524-
compilesketches.CompileSketches.ReportKeys.sketch: sketch_report_list
1524+
compilesketches.CompileSketches.ReportKeys.sketches: sketch_report_list
15251525
}
15261526

15271527
compile_sketches.get_sizes_summary_report.assert_called_once_with(compile_sketches,
@@ -1537,7 +1537,7 @@ def test_get_sketches_report(monkeypatch, mocker):
15371537
+ github_repository
15381538
+ "/commit/"
15391539
+ current_git_ref),
1540-
compilesketches.CompileSketches.ReportKeys.sketch: sketch_report_list
1540+
compilesketches.CompileSketches.ReportKeys.sketches: sketch_report_list
15411541
}
15421542

15431543

0 commit comments

Comments
 (0)