Skip to content

Commit be1fb30

Browse files
committed
Use pytest assertions in Python unit tests
1 parent 4c44177 commit be1fb30

File tree

1 file changed

+12
-10
lines changed

1 file changed

+12
-10
lines changed

reportsizetrends/tests/test_reportsizetrends.py

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
import json
33
import unittest.mock
44

5+
import pytest
6+
57
import reportsizetrends
68

79

@@ -24,7 +26,7 @@ class TestReportsizetrends(unittest.TestCase):
2426

2527
# @unittest.skip("")
2628
def test_set_verbosity(self):
27-
with self.assertRaises(TypeError):
29+
with pytest.raises(TypeError):
2830
reportsizetrends.set_verbosity(enable_verbosity=2)
2931
reportsizetrends.set_verbosity(enable_verbosity=True)
3032
reportsizetrends.set_verbosity(enable_verbosity=False)
@@ -116,7 +118,7 @@ def test_get_heading_row_data(self):
116118
Service.execute = unittest.mock.MagicMock(return_value=heading_row_data)
117119
report_size_trends.service = Service()
118120

119-
self.assertEqual(heading_row_data, report_size_trends.get_heading_row_data())
121+
assert heading_row_data == report_size_trends.get_heading_row_data()
120122
spreadsheet_range = (sheet_name + "!" + report_size_trends.heading_row_number + ":"
121123
+ report_size_trends.heading_row_number)
122124
Service.get.assert_called_once_with(spreadsheetId=spreadsheet_id, range=spreadsheet_range)
@@ -170,15 +172,15 @@ def test_get_data_column_letters(self):
170172
ram=11)
171173
heading_row_data = {"values": [["foo", "bar"]]}
172174
column_letters = report_size_trends.get_data_column_letters(heading_row_data)
173-
self.assertEqual(False, column_letters["populated"])
174-
self.assertEqual("C", column_letters["flash"])
175-
self.assertEqual("D", column_letters["ram"])
175+
assert column_letters["populated"] is False
176+
assert "C" == column_letters["flash"]
177+
assert "D" == column_letters["ram"]
176178

177179
heading_row_data = {"values": [["foo", report_size_trends.fqbn + report_size_trends.flash_heading_indicator]]}
178180
column_letters = report_size_trends.get_data_column_letters(heading_row_data)
179-
self.assertEqual(True, column_letters["populated"])
180-
self.assertEqual("B", column_letters["flash"])
181-
self.assertEqual("C", column_letters["ram"])
181+
assert column_letters["populated"] is True
182+
assert "B" == column_letters["flash"]
183+
assert "C" == column_letters["ram"]
182184

183185
# @unittest.skip("")
184186
def test_populate_data_column_headings(self):
@@ -231,13 +233,13 @@ def test_get_current_row(self):
231233
Service.execute = unittest.mock.MagicMock(return_value={"values": [["foo"], [commit_hash]]})
232234
report_size_trends.service = Service()
233235

234-
self.assertEqual({"populated": True, "number": 2}, report_size_trends.get_current_row())
236+
assert {"populated": True, "number": 2} == report_size_trends.get_current_row()
235237
spreadsheet_range = (sheet_name + "!" + report_size_trends.commit_hash_column_letter + ":"
236238
+ report_size_trends.commit_hash_column_letter)
237239
Service.get.assert_called_once_with(spreadsheetId=spreadsheet_id, range=spreadsheet_range)
238240
Service.execute.assert_called_once()
239241
Service.execute = unittest.mock.MagicMock(return_value={"values": [["foo"], ["bar"]]})
240-
self.assertEqual({"populated": False, "number": 3}, report_size_trends.get_current_row())
242+
assert {"populated": False, "number": 3} == report_size_trends.get_current_row()
241243

242244
# @unittest.skip("")
243245
def test_create_row(self):

0 commit comments

Comments
 (0)