add libxml2 and fix build issues #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the build environment by upgrading to libusb 1.0.28, adding libxml2, fixing Ubuntu build issues, and centralizing toolchain selection.
- Remove outdated MSVC project files and old libusb docs
- Update
build_libs.shto bump libusb/libusb-compat and add libxml2 build - Introduce
configure_toolchain.shand switch Dockerfiles to Ubuntu 22.04 with clang-13
Reviewed Changes
Copilot reviewed 299 out of 299 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| deps/libusb-1.0.26/msvc/* | Remove legacy Visual Studio project and filter files |
| deps/libusb-1.0.26/libusb/* | Delete version_nano.h and darwin_usb.h (macOS backend) |
| deps/libusb-1.0.26/INSTALL | Remove detailed install instructions |
| deps/build_libs.sh | Bump libusb versions, comment out CMake step, add libxml2 |
| configure_toolchain.sh | New script to set CC, CXX, and related toolchain vars |
| Taskfile.yml | Exclude deps/*, simplify shell-file detection |
| Dockerfile | Switch to Ubuntu 22.04, install clang-13, add symlinks |
Comments suppressed due to low confidence (5)
deps/libusb-1.0.26/libusb/version_nano.h:1
- Removal of
version_nano.hdeletes theLIBUSB_NANOdefinition; any code checking this macro will now fail. Please update or replace this version constant to match the new libusb release.
#define LIBUSB_NANO 11724
deps/libusb-1.0.26/libusb/os/darwin_usb.h:1
- The entire Darwin USB backend header was removed, so any macOS builds will break due to missing
darwin_usb.h. Restore this file or update the macOS build path accordingly.
/* darwin backend for libusb 1.0 */
deps/libusb-1.0.26/INSTALL:1
- [nitpick] The
INSTALLfile was deleted, removing valuable installation guidance. Consider keeping or relocating these instructions in a project-leveldocs/directory.
Installation Instructions
Dockerfile:8
- Typo in comment: "Intall" should be "Install".
# Intall clang compiler used by macos
Taskfile.yml:118
- [nitpick] Combine the
-nametests with-typeusing parentheses to ensure the intended precedence, e.g.,( -name '*.bash' -o -name '*.sh' ) -a -type f.
- -name '*.bash' -or -name '*.sh' -and -type f
Co-authored-by: Copilot <[email protected]>
cmaglie
approved these changes
May 19, 2025
per1234
added
type: imperfection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repository wasn't compiling anymore due to some updates in the Ubuntu image.
The core changes are:
libusbandlibusb-compactlibxml2libraryconfigure_toolchain.shscript to easily select the toolchain to useYou can now select a cross compiler by setting the
CROSS_COMPILEenv variable, for instance