Skip to content

Commit 285f54f

Browse files
committed
Added StringQuotedSplit function
1 parent 526c340 commit 285f54f

File tree

3 files changed

+178
-0
lines changed

3 files changed

+178
-0
lines changed

properties.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,9 @@ This library has methods to parse this kind of files into a Map object.
5959
The Map object has many helper methods to accomplish some common operation
6060
on this kind of data like cloning, merging, comparing and also extracting
6161
a submap or generating a map-of-submaps from the first "level" of the hierarchy.
62+
63+
On the Arduino platform the properties are used to populate command line recipes
64+
so there are some methods to help this task like SplitQuotedString or ExpandPropsInString.
6265
*/
6366
package properties
6467

strings.go

Lines changed: 104 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,104 @@
1+
/*
2+
* This file is part of PropertiesMap library.
3+
*
4+
* Copyright 2017-2018 Arduino AG (http://www.arduino.cc/)
5+
*
6+
* PropertiesMap library is free software; you can redistribute it and/or modify
7+
* it under the terms of the GNU General Public License as published by
8+
* the Free Software Foundation; either version 2 of the License, or
9+
* (at your option) any later version.
10+
*
11+
* This program is distributed in the hope that it will be useful,
12+
* but WITHOUT ANY WARRANTY; without even the implied warranty of
13+
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14+
* GNU General Public License for more details.
15+
*
16+
* You should have received a copy of the GNU General Public License
17+
* along with this program; if not, write to the Free Software
18+
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
19+
*
20+
* As a special exception, you may use this file as part of a free software
21+
* library without restriction. Specifically, if other files instantiate
22+
* templates or use macros or inline functions from this file, or you compile
23+
* this file and link it with other files to produce an executable, this
24+
* file does not by itself cause the resulting executable to be covered by
25+
* the GNU General Public License. This exception does not however
26+
* invalidate any other reasons why the executable file might be covered by
27+
* the GNU General Public License.
28+
*/
29+
30+
package properties
31+
32+
import (
33+
"fmt"
34+
"strings"
35+
"unicode/utf8"
36+
)
37+
38+
// SplitQuotedString splits a string by spaces and at the same time allows
39+
// to use spaces in a single element of the split using quote characters.
40+
//
41+
// For example the call:
42+
// SplitQuotedString(`This 'is an' "Hello World!" example`, `'"`, false)
43+
// returns the following array:
44+
// []string{"This", "is an", "Hello World!", "example"}
45+
func SplitQuotedString(src string, quoteChars string, acceptEmptyArguments bool) ([]string, error) {
46+
// Make a map of valid quote runes
47+
isQuote := map[rune]bool{}
48+
for _, c := range quoteChars {
49+
isQuote[c] = true
50+
}
51+
52+
result := []string{}
53+
54+
var escapingChar rune
55+
escapedArg := ""
56+
57+
for _, current := range strings.Split(src, " ") {
58+
if escapingChar == 0 {
59+
first, size := firstRune(current)
60+
if !isQuote[first] {
61+
if acceptEmptyArguments || len(strings.TrimSpace(current)) > 0 {
62+
result = append(result, current)
63+
}
64+
continue
65+
}
66+
67+
escapingChar = first
68+
current = current[size:]
69+
escapedArg = ""
70+
}
71+
72+
last, size := lastRune(current)
73+
if last != escapingChar {
74+
escapedArg += current + " "
75+
continue
76+
}
77+
78+
escapedArg += current[:len(current)-size]
79+
if acceptEmptyArguments || len(strings.TrimSpace(escapedArg)) > 0 {
80+
result = append(result, escapedArg)
81+
}
82+
escapingChar = 0
83+
}
84+
85+
if escapingChar != 0 {
86+
return nil, fmt.Errorf("invalid quoting, no closing `%c` char found", escapingChar)
87+
}
88+
89+
return result, nil
90+
}
91+
92+
func firstRune(s string) (rune, int) {
93+
if len(s) == 0 || !utf8.ValidString(s) {
94+
return 0, 0
95+
}
96+
return utf8.DecodeRuneInString(s)
97+
}
98+
99+
func lastRune(s string) (rune, int) {
100+
if len(s) == 0 || !utf8.ValidString(s) {
101+
return 0, 0
102+
}
103+
return utf8.DecodeLastRuneInString(s)
104+
}

strings_test.go

Lines changed: 71 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,71 @@
1+
/*
2+
* This file is part of PropertiesMap library.
3+
*
4+
* Copyright 2017-2018 Arduino AG (http://www.arduino.cc/)
5+
*
6+
* PropertiesMap library is free software; you can redistribute it and/or modify
7+
* it under the terms of the GNU General Public License as published by
8+
* the Free Software Foundation; either version 2 of the License, or
9+
* (at your option) any later version.
10+
*
11+
* This program is distributed in the hope that it will be useful,
12+
* but WITHOUT ANY WARRANTY; without even the implied warranty of
13+
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14+
* GNU General Public License for more details.
15+
*
16+
* You should have received a copy of the GNU General Public License
17+
* along with this program; if not, write to the Free Software
18+
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
19+
*
20+
* As a special exception, you may use this file as part of a free software
21+
* library without restriction. Specifically, if other files instantiate
22+
* templates or use macros or inline functions from this file, or you compile
23+
* this file and link it with other files to produce an executable, this
24+
* file does not by itself cause the resulting executable to be covered by
25+
* the GNU General Public License. This exception does not however
26+
* invalidate any other reasons why the executable file might be covered by
27+
* the GNU General Public License.
28+
*/
29+
30+
package properties
31+
32+
import (
33+
"testing"
34+
35+
"github.com/stretchr/testify/require"
36+
)
37+
38+
func TestSplitQuotedString(t *testing.T) {
39+
res, err := SplitQuotedString(`this is a "test of quoting" another test`, `"`, true)
40+
require.NoError(t, err)
41+
require.EqualValues(t, res, []string{"this", "is", "a", "test of quoting", "another", "test"})
42+
}
43+
44+
func TestSplitQuotedStringMixedQuotes(t *testing.T) {
45+
res, err := SplitQuotedString(`this is a "test 'of' quoting" 'another test' "that's it"`, `"'`, true)
46+
require.NoError(t, err)
47+
require.EqualValues(t, res, []string{"this", "is", "a", "test 'of' quoting", "another test", "that's it"})
48+
}
49+
50+
func TestSplitQuotedStringEmptyArgsAllowed(t *testing.T) {
51+
res, err := SplitQuotedString(`this is a " test 'of' quoting " `, `"'`, true)
52+
require.NoError(t, err)
53+
require.EqualValues(t, res, []string{"this", "", "", "is", "", "a", " test 'of' quoting ", ""})
54+
55+
res, err = SplitQuotedString(`this is a " test 'of' quoting " `, `"'`, false)
56+
require.NoError(t, err)
57+
require.EqualValues(t, res, []string{"this", "is", "a", " test 'of' quoting "})
58+
}
59+
60+
func TestSplitQuotedStringWithUTF8(t *testing.T) {
61+
res, err := SplitQuotedString(`èthis is a testè of quoting`, `è`, true)
62+
require.NoError(t, err)
63+
require.EqualValues(t, res, []string{"this is a test", "of", "quoting"})
64+
}
65+
66+
func TestSplitQuotedStringInvalid(t *testing.T) {
67+
_, err := SplitQuotedString(`'this is' a 'test of quoting`, `"'`, true)
68+
require.Error(t, err)
69+
_, err = SplitQuotedString(`'this is' a "'test" of "quoting`, `"'`, true)
70+
require.Error(t, err)
71+
}

0 commit comments

Comments
 (0)