Merge pull request #268 from per1234/production-check-type

Add library type check to registry data file validator

Author: per1234

.github/workflows/assets/validate-registry/main.go

@@ -43,8 +43,29 @@ func main() {
 		os.Exit(1)
 	}
 
+	validTypes := map[string]bool{
+		"Arduino":     true,
+		"Contributed": true,
+		"Partner":     true,
+		"Recommended": true,
+		"Retired":     true,
+	}
+
 	nameMap := make(map[string]bool)
 	for _, entry := range rawRepos {
+		// Check entry types
+		if len(entry.Types) == 0 {
+			fmt.Fprintf(os.Stderr, "error: Type not specified for library \"%s\"\n", entry.LibraryName)
+			os.Exit(1)
+		}
+		for _, entryType := range entry.Types {
+			if _, valid := validTypes[entryType]; !valid {
+				fmt.Fprintf(os.Stderr, "error: Invalid type \"%s\" used by library \"%s\"\n", entryType, entry.LibraryName)
+				os.Exit(1)
+			}
+		}
+
+		// Check library name of the entry
 		if _, found := nameMap[entry.LibraryName]; found {
 			fmt.Fprintf(os.Stderr, "error: Registry data file contains duplicates of name %s\n", entry.LibraryName)
 			os.Exit(1)

.github/workflows/assets/validate-registry/tests/test_all.py

@@ -30,6 +30,8 @@
         ("nonexistent.txt", False),
         ("invalid-data-format.txt", False),
         ("invalid-url-format.txt", False),
+        ("no-type.txt", False),
+        ("invalid-type.txt", False),
         ("duplicate-url.txt", False),
         ("duplicate-name.txt", False),
         ("valid.txt", True),

.github/workflows/assets/validate-registry/tests/testdata/invalid-type.txt

@@ -0,0 +1,3 @@
+https://github.com/arduino-libraries/Scheduler.git|Arduino|Scheduler
+https://github.com/arduino-libraries/SD.git|foo|SD
+https://github.com/arduino-libraries/Servo.git|Recommended|Servo

.github/workflows/assets/validate-registry/tests/testdata/no-type.txt

@@ -0,0 +1,3 @@
+https://github.com/arduino-libraries/Scheduler.git|Arduino|Scheduler
+https://github.com/arduino-libraries/SD.git||SD
+https://github.com/arduino-libraries/Servo.git|Recommended|Servo