Skip to content

Conversation

sswartley
Copy link
Contributor

This is a pull request that would require two manual changes:

The first is to update the URL of a library that is already in the Library Manager. The library (GDXLib) was moved from an individual's GitHub account ("dvernier") to the official GitHub account for Vernier Science Education.

The second request that would require a manual change is for an update of the libraries name. The original library was misnamed in libraries.properties as "GDXLIb". The name has been corrected and updated as "GDXLib".

@github-actions github-actions bot added the topic: modification Change existing list entry label May 31, 2024
Copy link
Contributor

Hi @sswartley.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/VernierST/GDXLib:

Linting library in GDXLib
ERROR: Library name GDXLib not found in the Library Manager index. Library names are not allowed to change after being  
       added to the index.                                                                                              
       See: https://github.com/arduino/library-registry/blob/main/FAQ.md#how-can-i-change-a-librarys-name               
       (Rule LP018)                                                                                                     
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           
WARNING: Sketch(es) found outside examples and extras folders:                                    
           GDXLib                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD003)                                                                             

Linter results for project: 1 ERRORS, 2 WARNINGS

-------------------

Linting sketch in GDXLib/examples/GDXBuzzer

Linter results for project: no errors or warnings

-------------------

Linting sketch in GDXLib/examples/GDXDCU

Linter results for project: no errors or warnings

-------------------

Linting sketch in GDXLib/examples/GDXDemoSimple

Linter results for project: no errors or warnings

-------------------

Linting sketch in GDXLib/examples/GDXDemoWithI2CDisplay

Linter results for project: no errors or warnings

-------------------

Linting sketch in GDXLib/examples/GDXDemoWithSerialDisplay

Linter results for project: no errors or warnings

-------------------

Linting sketch in GDXLib/examples/GDXFinger

Linter results for project: no errors or warnings

-------------------

Linting sketch in GDXLib/examples/GDXLaserPointer

Linter results for project: no errors or warnings

-------------------

Linting sketch in GDXLib/examples/GDXMaskWithI2CDisplay

Linter results for project: no errors or warnings

-------------------

Linting sketch in GDXLib/examples/GDXServo

Linter results for project: no errors or warnings

-------------------

Linting sketch in GDXLib/examples/GDXSoundLevelTrafficLight

Linter results for project: no errors or warnings

-------------------

Linting sketch in GDXLib/examples/GDXStep

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 2 WARNINGS

Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @sswartley
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 May 31, 2024 22:02
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @sswartley. I am confirming your request.

Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests. They will merge this pull request when it is done. You will get a notification from GitHub at that time.

After that, you can monitor the indexing of the library via its dedicated logs web page.
Information about that here:
https://github.com/arduino/library-registry/blob/main/FAQ.md#can-i-check-on-library-releases-being-added-to-library-manager

@per1234 per1234 added the status: pending backend Depends on backend maintenance operations label Jun 1, 2024
@sswartley
Copy link
Contributor Author

Hello @per1234,

I have not received any notification or update on this request. I wanted to check to see if there was something I needed to do.

Thanks,

@MatteoPologruto MatteoPologruto self-assigned this Jun 13, 2024
Copy link
Contributor

@MatteoPologruto MatteoPologruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done:

2024/06/13 15:15:28 Loaded 7062 libraries from DB
Removing GDXLIb
Success!

@MatteoPologruto MatteoPologruto merged commit 21ee479 into arduino:main Jun 13, 2024
@MatteoPologruto MatteoPologruto added the conclusion: resolved Issue was resolved label Jun 13, 2024
@sswartley
Copy link
Contributor Author

Hi @per1234

I just wanted to check that there was not an issue with the GDXLib library. After it was moved to a new Github repository and renamed I made some changes to the library. This updated library was released as version 2.0.0. The Library Manager indexer did show it found 2.0.0, but it had errors in the library.properties file and did not update to this version. I then made changes to fix the error and released the updated version as 2.0.1. When I open Arduino IDE version 2.0.1 is available to be installed. However, when I check the log page for the library it does not show that it was updated.

I am checking the log page at: https://downloads.arduino.cc/libraries/logs/github.com/VernierST/GDXLib/

Can you confirm that there are no issues with the GDXLib library and that I did not make some mistakes? Thanks!

@per1234
Copy link
Contributor

per1234 commented Sep 19, 2024

Hi @sswartley. Unfortunately the Arduino web team have instated a draconian caching policy on the indexer log web pages so they are often days out of date.

As you noticed, the actual Library Manager index has been updated even though the logs didn't reflect that. So all is well.

@sswartley
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved status: pending backend Depends on backend maintenance operations topic: modification Change existing list entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants