Skip to content

Conversation

shahul-s-6029
Copy link
Contributor

added new repository for Zoho IOT Arduino SDK

added new repository for Zoho IOT Arduino SDK
@github-actions github-actions bot added the topic: submission Add library to the list label Sep 5, 2024
Copy link
Contributor

github-actions bot commented Sep 5, 2024

ERROR: Arduino Lint found errors with https://github.com/zoho/zoho-iot-sdk-arduino:

Linting library in zoho-iot-sdk-arduino
INFO: No header file found matching library name (ZOHO-IOT-SDK.h). Best practices are for primary header filename to    
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   
ERROR: library.properties url value is less than minimum length.                                             
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP056)                                                                                          
WARNING: library.properties url field value  does not have a valid URL format.                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP041)                                                                                          
WARNING: Unable to load the library.properties url field: Head "": unsupported protocol scheme ""              
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP042)                                                                                          
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           
WARNING: Sketch(es) found outside examples and extras folders:                                    
           zoho-iot-sdk-arduino/test/lib/ArduinoJson/examples/JsonConfigFile                      
           zoho-iot-sdk-arduino/test/lib/ArduinoJson/examples/JsonGeneratorExample                
           zoho-iot-sdk-arduino/test/lib/ArduinoJson/examples/JsonHttpClient                      
           zoho-iot-sdk-arduino/test/lib/ArduinoJson/examples/JsonParserExample                   
           zoho-iot-sdk-arduino/test/lib/ArduinoJson/examples/JsonServer                          
           zoho-iot-sdk-arduino/test/lib/ArduinoJson/examples/JsonUdpBeacon                       
           zoho-iot-sdk-arduino/test/lib/ArduinoJson/examples/ProgmemExample                      
           zoho-iot-sdk-arduino/test/lib/ArduinoJson/examples/StringExample                       
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD003)                                                                             

Linter results for project: 1 ERRORS, 5 WARNINGS

-------------------

Linting sketch in zoho-iot-sdk-arduino/examples/esp32_DHT_sensor

Linter results for project: no errors or warnings

-------------------

Linting sketch in zoho-iot-sdk-arduino/examples/esp32_TLS

Linter results for project: no errors or warnings

-------------------

Linting sketch in zoho-iot-sdk-arduino/examples/esp32_TLS_client_ca

Linter results for project: no errors or warnings

-------------------

Linting sketch in zoho-iot-sdk-arduino/examples/esp32_basic

Linter results for project: no errors or warnings

-------------------

Linting sketch in zoho-iot-sdk-arduino/examples/esp32_soil_moisture_sensor

Linter results for project: no errors or warnings

-------------------

Linting sketch in zoho-iot-sdk-arduino/examples/esp8266_basic

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 5 WARNINGS

Copy link
Contributor

github-actions bot commented Sep 5, 2024

Thanks for your interest in contributing to the Arduino Library Manager index @shahul-s-6029
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @shahul-s-6029. I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.

If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:

https://github.com/zoho/zoho-iot-sdk-arduino/blob/0.1.0/library.properties#L8

url=

❗ Remember to update the version field in the library's library.properties file as needed before making a release/tag.

Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will automatically be added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Sep 5, 2024
@shahul-s-6029
Copy link
Contributor Author

@ArduinoBot

Copy link
Contributor

github-actions bot commented Sep 5, 2024

Hello! I'm checking your submission again.

@github-actions github-actions bot removed the status: waiting for information More information must be provided before work can proceed label Sep 5, 2024
Copy link
Contributor

github-actions bot commented Sep 5, 2024

ERROR: Arduino Lint found errors with https://github.com/zoho/zoho-iot-sdk-arduino:

Linting library in zoho-iot-sdk-arduino
INFO: No header file found matching library name (ZOHO-IOT-SDK.h). Best practices are for primary header filename to    
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   
ERROR: library.properties url value is less than minimum length.                                             
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP056)                                                                                          
WARNING: library.properties url field value  does not have a valid URL format.                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP041)                                                                                          
WARNING: Unable to load the library.properties url field: Head "": unsupported protocol scheme ""              
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP042)                                                                                          
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           
WARNING: Sketch(es) found outside examples and extras folders:                                    
           zoho-iot-sdk-arduino/test/lib/ArduinoJson/examples/JsonConfigFile                      
           zoho-iot-sdk-arduino/test/lib/ArduinoJson/examples/JsonGeneratorExample                
           zoho-iot-sdk-arduino/test/lib/ArduinoJson/examples/JsonHttpClient                      
           zoho-iot-sdk-arduino/test/lib/ArduinoJson/examples/JsonParserExample                   
           zoho-iot-sdk-arduino/test/lib/ArduinoJson/examples/JsonServer                          
           zoho-iot-sdk-arduino/test/lib/ArduinoJson/examples/JsonUdpBeacon                       
           zoho-iot-sdk-arduino/test/lib/ArduinoJson/examples/ProgmemExample                      
           zoho-iot-sdk-arduino/test/lib/ArduinoJson/examples/StringExample                       
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD003)                                                                             

Linter results for project: 1 ERRORS, 5 WARNINGS

-------------------

Linting sketch in zoho-iot-sdk-arduino/examples/esp32_DHT_sensor

Linter results for project: no errors or warnings

-------------------

Linting sketch in zoho-iot-sdk-arduino/examples/esp32_TLS

Linter results for project: no errors or warnings

-------------------

Linting sketch in zoho-iot-sdk-arduino/examples/esp32_TLS_client_ca

Linter results for project: no errors or warnings

-------------------

Linting sketch in zoho-iot-sdk-arduino/examples/esp32_basic

Linter results for project: no errors or warnings

-------------------

Linting sketch in zoho-iot-sdk-arduino/examples/esp32_soil_moisture_sensor

Linter results for project: no errors or warnings

-------------------

Linting sketch in zoho-iot-sdk-arduino/examples/esp8266_basic

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 5 WARNINGS

Copy link
Contributor

github-actions bot commented Sep 5, 2024

Thanks for your interest in contributing to the Arduino Library Manager index @shahul-s-6029
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@shahul-s-6029
Copy link
Contributor Author

@ArduinoBot

Copy link
Contributor

github-actions bot commented Sep 5, 2024

Hello! I'm checking your submission again.

Copy link
Contributor

github-actions bot commented Sep 5, 2024

Arduino Lint has suggestions for possible improvements to https://github.com/zoho/zoho-iot-sdk-arduino:

Linting library in zoho-iot-sdk-arduino
INFO: No header file found matching library name (ZOHO-IOT-SDK.h). Best practices are for primary header filename to    
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: No license file found.                                                                                                                 
         See:                                                                                                                                   
         https://docs.github.com/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository
         (Rule LD002)                                                                                                                           
WARNING: Sketch(es) found outside examples and extras folders:                                    
           zoho-iot-sdk-arduino/test/lib/ArduinoJson/examples/JsonConfigFile                      
           zoho-iot-sdk-arduino/test/lib/ArduinoJson/examples/JsonGeneratorExample                
           zoho-iot-sdk-arduino/test/lib/ArduinoJson/examples/JsonHttpClient                      
           zoho-iot-sdk-arduino/test/lib/ArduinoJson/examples/JsonParserExample                   
           zoho-iot-sdk-arduino/test/lib/ArduinoJson/examples/JsonServer                          
           zoho-iot-sdk-arduino/test/lib/ArduinoJson/examples/JsonUdpBeacon                       
           zoho-iot-sdk-arduino/test/lib/ArduinoJson/examples/ProgmemExample                      
           zoho-iot-sdk-arduino/test/lib/ArduinoJson/examples/StringExample                       
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD003)                                                                             

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

Linting sketch in zoho-iot-sdk-arduino/examples/esp32_DHT_sensor

Linter results for project: no errors or warnings

-------------------

Linting sketch in zoho-iot-sdk-arduino/examples/esp32_TLS

Linter results for project: no errors or warnings

-------------------

Linting sketch in zoho-iot-sdk-arduino/examples/esp32_TLS_client_ca

Linter results for project: no errors or warnings

-------------------

Linting sketch in zoho-iot-sdk-arduino/examples/esp32_basic

Linter results for project: no errors or warnings

-------------------

Linting sketch in zoho-iot-sdk-arduino/examples/esp32_soil_moisture_sensor

Linter results for project: no errors or warnings

-------------------

Linting sketch in zoho-iot-sdk-arduino/examples/esp8266_basic

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 2 WARNINGS

@github-actions github-actions bot merged commit 0780b83 into arduino:main Sep 5, 2024
12 checks passed
Copy link
Contributor

github-actions bot commented Sep 5, 2024

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/zoho/zoho-iot-sdk-arduino/

github-actions bot pushed a commit that referenced this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: submission Add library to the list

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants