Skip to content

Conversation

piscodev
Copy link
Contributor

@piscodev piscodev commented Sep 26, 2024

Request for adding wrapper for Arduino UNO R4 WiFi HttpClient

@github-actions github-actions bot added the topic: submission Add library to the list label Sep 26, 2024
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/piscodev/r4httpclient:

Linting library in r4httpclient
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in r4httpclient/examples/GET_request
WARNING: Sketch file/folder name mismatch. The primary sketch file name must match the folder: GET_request.ino
         See: https://arduino.github.io/arduino-cli/latest/sketch-specification/#primary-sketch-file          
         (Rule SS001)                                                                                         
WARNING: request_get.pde uses deprecated .pde file extension. Use .ino for Arduino sketches.          
         See: https://arduino.github.io/arduino-cli/latest/sketch-specification/#additional-code-files
         (Rule SS004)                                                                                 

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

Linting sketch in r4httpclient/examples/POST_request
WARNING: Sketch file/folder name mismatch. The primary sketch file name must match the folder: POST_request.ino
         See: https://arduino.github.io/arduino-cli/latest/sketch-specification/#primary-sketch-file           
         (Rule SS001)                                                                                          
WARNING: request_arduinojson_post.pde uses deprecated .pde file extension. Use .ino for Arduino sketches.
         See: https://arduino.github.io/arduino-cli/latest/sketch-specification/#additional-code-files   
         (Rule SS004)                                                                                    

Linter results for project: 0 ERRORS, 2 WARNINGS

-------------------

Linter results for projects: 0 ERRORS, 5 WARNINGS

@github-actions github-actions bot merged commit 3d6c8c3 into arduino:main Sep 26, 2024
9 checks passed
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/piscodev/r4httpclient/

github-actions bot pushed a commit that referenced this pull request Sep 26, 2024
@piscodev
Copy link
Contributor Author

@ArduinoBot

@per1234
Copy link
Contributor

per1234 commented Sep 27, 2024

Hello @piscodev. The automated system here only operates on open pull requests. Since your submission was already accepted and the pull request merged, the bot won't pay any more attention to this pull request.

But this human is happy to provide assistance. Was there something you needed from the bot?

@piscodev
Copy link
Contributor Author

piscodev commented Sep 27, 2024

I thought calling the bot re-scrapes the index. Made some mistake on my properties, it was v1.0.1 but my release were still v1, then I updated the properties back to v1 back after being scraped. Now, I just decided to make some updates for v1.0.2. Anyway, thanks 👍

@piscodev
Copy link
Contributor Author

@ArduinoBot

I have updated to 1.0.2 but it hasnt scraped the new version, what could have happened?

@tobozo
Copy link
Contributor

tobozo commented Sep 28, 2024

hi @per1234 it looks like there's an encoding problem with the character ñ in library.properties file (author field)

when library.properties is encoded as ascii, ñ = 0xf1, but library registry lists this:
image

when library.properties is encoded as unicode, ñ = 0xC3B1 (or \u00F1), but library registry lists this (double-escape?):
image

the registry has a couple of libraries using this character and it's display normally in the json flow, however it seems to give problems with @piscodev's properties file

do you have a suggestion on how to produce a lossless properties file?

@per1234
Copy link
Contributor

per1234 commented Oct 2, 2024

@ArduinoBot

@piscodev I already explained to you that mentioning the bot doesn't have any effect after your pull request has been merged. So why are you still doing it???????????????

I have updated to 1.0.2 but it hasnt scraped the new version

I see it in my Library Manager. Please check again. It takes time for the new release to be indexed and then the updated index to work through the cache. We give a conservative estimate of availability within one day's time. So please don't expect instant results.

@per1234
Copy link
Contributor

per1234 commented Oct 2, 2024

do you have a suggestion on how to produce a lossless properties file?

Hi @tobozo. I compared @piscodev's library.properties file to this one, which is correctly rendered:

https://gitlab.com/xoan/escornabot-extlib/-/raw/master/library.properties

I found that the file encoding of the working one is UTF-8, while the encoding of @piscodev's file is ISO-8859:

$ mkdir -p /tmp/library_properties_encoding/R4HttpClient

$ wget --output-document=/tmp/library_properties_encoding/R4HttpClient/library.properties https://github.com/piscodev/r4httpclient/raw/refs/heads/main/library.properties

[...]

$ mkdir -p /tmp/library_properties_encoding/EscornabotEXT

$ wget --output-document=/tmp/library_properties_encoding/EscornabotEXT/library.properties https://gitlab.com/xoan/escornabot-extlib/-/raw/master/library.properties

[...]

$ file /tmp/library_properties_encoding/R4HttpClient/library.properties /tmp/library_properties_encoding/EscornabotEXT/library.properties

/tmp/library_properties_encoding/R4HttpClient/library.properties:  ISO-8859 text
/tmp/library_properties_encoding/EscornabotEXT/library.properties: Unicode text, UTF-8 text, with very long lines (353)

So it should be possible to fix the rendering problem by changing the file encoding to UTF-8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: submission Add library to the list

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants