Skip to content

Conversation

@gfretin
Copy link
Contributor

@gfretin gfretin commented Sep 30, 2024

Request to add the Arduino library RoboCore BRIICK Keypad.

gfretin added 3 commits July 8, 2024 17:11
Added the library "RoboCore Rocky".
Added the Arduino library RoboCore BRIICK Keypad.
@github-actions github-actions bot added the topic: submission Add library to the list label Sep 30, 2024
@github-actions
Copy link
Contributor

A problem was found with your submission https://github.com/RoboCore/RoboCore_BRIICK_Keypad

ERROR: Unable to load submission URL. Is the repository public?

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @gfretin
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@gfretin
Copy link
Contributor Author

gfretin commented Sep 30, 2024

@ArduinoBot, the repository ( https://github.com/RoboCore/RoboCore_BRIICK_Keypad ) is already public.

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/RoboCore/RoboCore_BRIICK_Keypad:

Linting library in RoboCore_BRIICK_Keypad
INFO: No header file found matching library name (RoboCore_-_BRIICK_Keypad.h). Best practices are for primary header    
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name value RoboCore - BRIICK Keypad is longer than the recommended length of 16 characters.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format        
         (Rule LP010)                                                                                                  
WARNING: library.properties name RoboCore - BRIICK Keypad contains spaces. Although supported, best practices is to not 
         use spaces.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: Unable to load the library.properties url field: 404 Not Found                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP042)                                                                                          

Linter results for project: 0 ERRORS, 3 WARNINGS

-------------------

Linting sketch in RoboCore_BRIICK_Keypad/examples/Blink

Linter results for project: no errors or warnings

-------------------

Linting sketch in RoboCore_BRIICK_Keypad/examples/I2C_Scanner

Linter results for project: no errors or warnings

-------------------

Linting sketch in RoboCore_BRIICK_Keypad/examples/Read_Buttons

Linter results for project: no errors or warnings

-------------------

Linting sketch in RoboCore_BRIICK_Keypad/examples/Read_Buttons_With_LED

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 3 WARNINGS

@github-actions github-actions bot merged commit 3c0e057 into arduino:main Sep 30, 2024
12 checks passed
@github-actions
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/RoboCore/RoboCore_BRIICK_Keypad/

github-actions bot pushed a commit that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: submission Add library to the list

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant