-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add dwiBus Library to Arduino Library Manager #5317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
❌ ERROR: Arduino Lint found errors with https://github.com/dralicimen/dwiBus: |
|
Thanks for your interest in contributing to the Arduino Library Manager index @dralicimen After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
|
@ArduinoBot check this again |
|
Hello! I'm checking your submission again. |
|
❌ ERROR: Arduino Lint found errors with https://github.com/dralicimen/dwiBus: |
|
Thanks for your interest in contributing to the Arduino Library Manager index @dralicimen After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
per1234
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello . I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.
If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:
https://github.com/dralicimen/dwiBus/tree/v1.0.0/examples
(note that the example sketches still had the invalid names at the tagged point in the revision history)
❗ Remember to update the version field in the library's library.properties file as needed before making a release/tag.
Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will automatically be added to Library Manager.
If you have any questions or concerns, please let me know.
Regards, Per
|
Hello! I'm checking your submission again. |
|
@ArduinoBot <https://github.com/ArduinoBot>
Saygılarımla
Ali ÇİMEN (Ph.D.)
Computer & Data Science
per1234 ***@***.***>, 29 Eki 2024 Sal, 02:52 tarihinde şunu
yazdı:
… ***@***.**** commented on this pull request.
Hello . I see you have fixed the error reported by the bot. However,
Library Manager works exclusively from Git tags, so the bot won't be able
to see the fix you made until you create a new release
<https://docs.github.com/en/github/administering-a-repository/releasing-projects-on-github/managing-releases-in-a-repository>
or tag <https://git-scm.com/docs/git-tag> in the library repository.
If you look at the repository contents at the latest tag, you can see that
the version the bot is checking still has the problem:
https://github.com/dralicimen/dwiBus/tree/v1.0.0/examples
(note that the example sketches still had the invalid names at the tagged
point in the revision history)
❗ Remember to update the version field in the library's library.properties
file
<https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format>
as needed before making a release/tag.
Once you have done that, simply mention ***@***.**** in a comment here
to trigger it to run the automated checks again. After those are passing,
your library will automatically be added to Library Manager.
If you have any questions or concerns, please let me know.
Regards, Per
—
Reply to this email directly, view it on GitHub
<#5317 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMP35LTWGZRTWRWRHGMMXW3Z53E3VAVCNFSM6AAAAABQYPNJ56VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMBQGQ2DQNRVGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hello! I'm checking your submission again. |
|
Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index. The library(s) will be available for installation via Library Manager within a day's time. You can check the logs from the Library Manager indexer for your library(s) here: |
This pull request adds the dwiBus library, a communication protocol for Arduino and ESP devices supporting packet fragmentation and CRC-based error handling. The repository URL has been added to repositories.txt. @ArduinoBot