Skip to content

Conversation

@cvmanjoo
Copy link
Contributor

@cvmanjoo cvmanjoo commented Dec 6, 2024

Adding LM75 to library repository.

@github-actions github-actions bot added the topic: submission Add library to the list label Dec 6, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

ERROR: Arduino Lint found errors with https://github.com/cvmanjoo/LM75:

Linting library in LM75
ERROR: library.properties sentence value is less than minimum length.                                        
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP032)                                                                                          
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   

Linter results for project: 1 ERRORS, 1 WARNINGS

-------------------

Linting sketch in LM75/examples/LM75_Functions

Linter results for project: no errors or warnings

-------------------

Linting sketch in LM75/examples/LM75_GetTemp

Linter results for project: no errors or warnings

-------------------

Linting sketch in LM75/examples/LM75_Info

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 1 WARNINGS

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Thanks for your interest in contributing to the Arduino Library Manager index @cvmanjoo
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@cvmanjoo
Copy link
Contributor Author

cvmanjoo commented Dec 6, 2024

@ArduinoBot Recheck please 😊

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

ERROR: Arduino Lint found errors with https://github.com/cvmanjoo/LM75:

Linting library in LM75
ERROR: library.properties sentence value is less than minimum length.                                        
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP032)                                                                                          
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   

Linter results for project: 1 ERRORS, 1 WARNINGS

-------------------

Linting sketch in LM75/examples/LM75_Functions

Linter results for project: no errors or warnings

-------------------

Linting sketch in LM75/examples/LM75_GetTemp

Linter results for project: no errors or warnings

-------------------

Linting sketch in LM75/examples/LM75_Info

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 1 WARNINGS

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Thanks for your interest in contributing to the Arduino Library Manager index @cvmanjoo
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@cvmanjoo
Copy link
Contributor Author

cvmanjoo commented Dec 6, 2024

@ArduinoBot Recheck again please 😊

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

ERROR: Arduino Lint found errors with https://github.com/cvmanjoo/LM75:

Linting library in LM75
ERROR: library.properties sentence value is less than minimum length.                                        
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP032)                                                                                          
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   

Linter results for project: 1 ERRORS, 1 WARNINGS

-------------------

Linting sketch in LM75/examples/LM75_Functions

Linter results for project: no errors or warnings

-------------------

Linting sketch in LM75/examples/LM75_GetTemp

Linter results for project: no errors or warnings

-------------------

Linting sketch in LM75/examples/LM75_Info

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 1 WARNINGS

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Thanks for your interest in contributing to the Arduino Library Manager index @cvmanjoo
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@cvmanjoo
Copy link
Contributor Author

cvmanjoo commented Dec 6, 2024

@ArduinoBot Recheck please 😊

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

ERROR: Arduino Lint found errors with https://github.com/cvmanjoo/LM75:

Linting library in LM75
ERROR: library.properties sentence value is less than minimum length.                                        
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP032)                                                                                          
WARNING: The library.properties paragraph field repeats the sentence field. These are displayed together so redundancy  
         is not needed.                                                                                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP036)                                                                                                   

Linter results for project: 1 ERRORS, 1 WARNINGS

-------------------

Linting sketch in LM75/examples/LM75_Functions

Linter results for project: no errors or warnings

-------------------

Linting sketch in LM75/examples/LM75_GetTemp

Linter results for project: no errors or warnings

-------------------

Linting sketch in LM75/examples/LM75_Info

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 1 WARNINGS

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Thanks for your interest in contributing to the Arduino Library Manager index @cvmanjoo
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@cvmanjoo
Copy link
Contributor Author

cvmanjoo commented Dec 6, 2024

What is the minimum length for library.properties sentence value?

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @cvmanjoo. I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.

If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:

https://github.com/cvmanjoo/LM75/blob/v1.1.0/library.properties#L5

sentence=

❗ Remember to update the version field in the library's library.properties file as needed before making a release/tag.

Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will automatically be added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Dec 6, 2024
@cvmanjoo
Copy link
Contributor Author

cvmanjoo commented Dec 6, 2024

@ArduinoBot Recheck please 😊

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Hello! I'm checking your submission again.

@github-actions github-actions bot removed the status: waiting for information More information must be provided before work can proceed label Dec 6, 2024
@github-actions github-actions bot merged commit 86a6f3d into arduino:main Dec 6, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 6, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/cvmanjoo/LM75/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: submission Add library to the list

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants