Skip to content

Conversation

@alfan459
Copy link
Contributor

I made improvements to the previous library

@github-actions github-actions bot added the topic: submission Add library to the list label Dec 22, 2024
@github-actions
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/alfan459/LinearRegressionModel:

Linting library in LinearRegressionModel
WARNING: Invalid category field value MachineLearning in library.properties                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP038)                                                                                          
ERROR: library.properties url value is less than minimum length.                                             
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP056)                                                                                          
WARNING: library.properties url field value  does not have a valid URL format.                                 
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP041)                                                                                          
WARNING: Unable to load the library.properties url field: Head "": unsupported protocol scheme ""              
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP042)                                                                                          
WARNING: Sketch(es) found outside examples and extras folders:                                    
           LinearRegressionModel/example/Basic_usage                                              
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD003)                                                                             
WARNING: Potentially misspelled examples folder name found: LinearRegressionModel/example         
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD005)                                                                             

Linter results for project: 1 ERRORS, 5 WARNINGS

-------------------

Linting sketch in LinearRegressionModel/example/Basic_usage

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 5 WARNINGS

@github-actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/alfan459/ElasticNetModel:

Linting library in ElasticNetModel
WARNING: Invalid category field value Machine Learning in library.properties                                   
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP038)                                                                                          
WARNING: Sketch(es) found outside examples and extras folders:                                    
           ElasticNetModel/example/Basic_usage                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD003)                                                                             
WARNING: Potentially misspelled examples folder name found: ElasticNetModel/example               
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD005)                                                                             

Linter results for project: 0 ERRORS, 3 WARNINGS

-------------------

Linting sketch in ElasticNetModel/example/Basic_usage

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 3 WARNINGS

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @alfan459
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @alfan459. I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the "LinearRegressionModel" library's repository.

If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:

https://github.com/alfan459/LinearRegressionModel/blob/v1.0.0/library.properties#L8

url=

❗ Remember to update the version field in the library's library.properties file as needed before making a release/tag.

Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will automatically be added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Dec 22, 2024
@alfan459
Copy link
Contributor Author

@ArduinoBot

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions github-actions bot removed the status: waiting for information More information must be provided before work can proceed label Dec 22, 2024
@github-actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/alfan459/LinearRegressionModel:

Linting library in LinearRegressionModel
WARNING: Invalid category field value Machine Learning in library.properties                                   
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP038)                                                                                          

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in LinearRegressionModel/examples/Basic_usage

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 1 WARNINGS

@github-actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/alfan459/ElasticNetModel:

Linting library in ElasticNetModel
WARNING: Invalid category field value Machine Learning in library.properties                                   
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP038)                                                                                          
WARNING: Sketch(es) found outside examples and extras folders:                                    
           ElasticNetModel/example/Basic_usage                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD003)                                                                             
WARNING: Potentially misspelled examples folder name found: ElasticNetModel/example               
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD005)                                                                             

Linter results for project: 0 ERRORS, 3 WARNINGS

-------------------

Linting sketch in ElasticNetModel/example/Basic_usage

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 3 WARNINGS

@github-actions github-actions bot merged commit 5514e6b into arduino:main Dec 22, 2024
13 checks passed
@github-actions
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/alfan459/ElasticNetModel/
http://downloads.arduino.cc/libraries/logs/github.com/alfan459/LinearRegressionModel/

github-actions bot pushed a commit that referenced this pull request Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: submission Add library to the list

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants