Simplify registry validation check workflows #5845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
added
type: enhancement
cmaglie
force-pushed
the
use-new-lib-engine
branch
from
8ee36ba to
19a742c
Compare
cmaglie
force-pushed
the
use-new-lib-engine
branch
from
19a742c to
74dbd56
Compare
cmaglie
force-pushed
the
use-new-lib-engine
branch
from
9a2dd32 to
d89b0e9
Compare
per1234
requested changes
Jan 31, 2025
There was a problem hiding this comment.
These are now obsolete/superfluous and so should be removed:
- https://github.com/arduino/library-registry/blob/use-new-lib-engine/.github/workflows/check-python-task.yml
Lines 60 to 75 in d89b0e9
Lines 4 to 6 in d89b0e9
Line 13 in d89b0e9
library-registry/pyproject.toml
Lines 15 to 19 in d89b0e9
(and runpoetry lockto sync the lockfile)- https://github.com/arduino/library-registry/blob/use-new-lib-engine/.gitignore (at least the obsolete entries)
I've applied all the requested changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the GitHub Action workflow that makes the validation check of the registry file.
Previously a golang project made for this purpose was built and run. Now it uses directly the library repository engine to perform this task. This change will simplify the maintenance of this repository since we no longer need to maintain a separate golang project.