- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 2.2k
 
Update repositories.txt #5849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update repositories.txt #5849
Conversation
https://github.com/closedcube/ is dead I found and fix error in this library. I worked on other fork of library.
| 
           Hi @malarz-supla. If you intended to submit a library, please check the instructions and update your pull request if necessary:  | 
    
| 
           Arduino Lint has suggestions for possible improvements to https://github.com/malarz-supla/ClosedCube_SHT31D_Arduino:  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @malarz-supla. Thanks for your interest in contributing to the Arduino Library Manager.
We only change the URLs of libraries when the request is received from or by approval of the library maintainer. So I can not accept your request.
However, you are very welcome to submit your fork of the library to the Arduino Library Manager Registry, leaving the closedcube registration intact.
If you want to do that, please note that each library must have a unique name. The library name is defined by the name property in the library's library.properties metadata file. The name configured for the library in your fork is currently "ClosedCube SHT31D":
https://github.com/malarz-supla/ClosedCube_SHT31D_Arduino/blob/1.5.2/library.properties#L1
name=ClosedCube SHT31D
That name is already taken, so you must change it. I'll provide an overview of the procedure:
- Change the value of the 
nameproperty in your library'slibrary.propertiesfile to a unique name.
ⓘ You can search the Arduino IDE Library Manager to check whether a prospective name is available. - Bump the value of the 
versionfield in the library'slibrary.propertiesmetadata file. - Create a new release or tag in the library repository.
 - Follow the instructions here to submit the library to the registry:
https://github.com/arduino/library-registry#adding-a-library-to-library-manager 
I'll continue to monitor this pull request thread, so if you have any questions or concerns, just add a comment on the thread and I'll provide further assistance.
Regards, Per
| 
           @per1234 There is a small bug in the original ClosedCube library that (at least for me) caused compilation errors. Unfortunately, all ClosedCube repositories are removed/hidden (see https://github.com/closedcube/) and I can't add my patch directly to the library. I wanted to share the solution, but I think the rules adopted in the Arduino project do not allow for an easy way to do it. The patched library is neither "new" nor "mine". It is still the ClosedCube library and I haven't even looked at most of its code.  | 
    
| 
           Hi @malarz-supla. 
 You should not be so quick to give up on your endeavors. Encountering difficulties in technical projects is a fact of life. If you want to be successful in this field you must accept that and learn techniques for overcoming such difficulties to finally achieve success. 
 It makes perfect sense: You set the value of the  
 You must have realized this because you did remove the invalid characters from the library name: malarz-supla/ClosedCube_SHT31D_Arduino@3c18733 
 This is false. The changes that are needed in order for you to register your fork of the library are absolutely trivial. Someone who is competent enough to work with an SHT3x I2C digital humidity and temperature sensor should have no trouble achieving this with a little bit of perseverance. 
 You are the maintainer of the library fork. You made the decision to submit the library you maintain. You must take responsibility for it.  | 
    
https://github.com/closedcube/ is dead
I found and fix error in this library.
I worked on other fork of library.