Skip to content

Conversation

@BjoernLuig
Copy link
Contributor

No description provided.

Add library to read data from the SB041 solar charger designed for the senseBox.
@github-actions github-actions bot added the topic: submission Add library to the list label Jan 31, 2025
@github-actions
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/sensebox/rg15-arduino-lib/:

Linting library in rg15-arduino-lib
INFO: No header file found matching library name (RG15_Library.h). Best practices are for primary header filename to    
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name RG15 Library contains spaces. Although supported, best practices is to not use spaces.
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format        
         (Rule LP015)                                                                                                  
WARNING: Library name RG15 Library contains "library". This is superfluous.                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP016)                                                                                          
WARNING: library.properties version value 1.0 is not compliant with the semver specification.
         See: https://semver.org/                                                            
         (Rule LP021)                                                                        
ERROR: Missing paragraph field in library.properties                                                         
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP034)                                                                                          
ERROR: Missing url field in library.properties                                                               
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP040)                                                                                          

Linter results for project: 2 ERRORS, 3 WARNINGS

-------------------

Linting sketch in rg15-arduino-lib/examples/direct-serial

Linter results for project: no errors or warnings

-------------------

Linting sketch in rg15-arduino-lib/examples/reset-baud-rate-9600

Linter results for project: no errors or warnings

-------------------

Linting sketch in rg15-arduino-lib/examples/test-all

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 2 ERRORS, 3 WARNINGS

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @BjoernLuig
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @BjoernLuig . Thanks for your interest in contributing to the Arduino Library Manager.

I see the bot reported a problem with your submission that will block its acceptance:

ERROR: Missing paragraph field in library.properties                                                         
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP034)                                                                                          
ERROR: Missing url field in library.properties                                                               
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP040)  

Please fix the problem so we can proceed with your submission.

You will need to do the following things:

  1. Add the missing fields to the library's library.properties file.
  2. Bump the value of the version field in the library's library.properties metadata file.
  3. Create a new release or tag in the library repository.
  4. Add a comment here in the pull request thread that mentions @ArduinoBot.

After that, the automated checks will run again. Once those are passing, your library will be automatically added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Feb 3, 2025
@github-actions github-actions bot removed the status: waiting for information More information must be provided before work can proceed label Feb 4, 2025
@arduino arduino deleted a comment from github-actions bot Feb 4, 2025
@arduino arduino deleted a comment from github-actions bot Feb 4, 2025
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello again @BjoernLuig. I see you added the missing metadata properties. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.

If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:

https://github.com/sensebox/rg15-arduino-lib/blob/v1.0.1/library.properties

(note that the metadata file did not contain paragraph and url properties at the tagged point in the revision history)

❗ Remember to update the version field in the library's library.properties file as needed before making a release/tag.

Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will be automatically added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Feb 4, 2025
@BjoernLuig
Copy link
Contributor Author

@per1234 thanks for helping.
I hadn't fixed the realese stuff yet and made a clean 1.0.0
@ArduinoBot hope it works now.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Hello! I'm checking your submission again.

@github-actions github-actions bot removed the status: waiting for information More information must be provided before work can proceed label Feb 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Arduino Lint has suggestions for possible improvements to https://github.com/sensebox/rg15-arduino-lib/:

Linting library in rg15-arduino-lib
INFO: No header file found matching library name (RG15-Arduino.h). Best practices are for primary header filename to    
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: Library name RG15-Arduino contains "Arduino". This is superfluous.                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
         (Rule LP014)                                                                                          

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in rg15-arduino-lib/examples/direct-serial

Linter results for project: no errors or warnings

-------------------

Linting sketch in rg15-arduino-lib/examples/reset-baud-rate-9600

Linter results for project: no errors or warnings

-------------------

Linting sketch in rg15-arduino-lib/examples/test-all

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 1 WARNINGS

@github-actions github-actions bot merged commit 057e28d into arduino:main Feb 5, 2025
14 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/sensebox/rg15-arduino-lib/

github-actions bot pushed a commit that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: submission Add library to the list

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants