-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add library for RG15 rain sensor #5857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add library to read data from the SB041 solar charger designed for the senseBox.
|
❌ ERROR: Arduino Lint found errors with https://github.com/sensebox/rg15-arduino-lib/: |
|
Thanks for your interest in contributing to the Arduino Library Manager index @BjoernLuig After resolving the issue, trigger this check again by doing one of the following:
❗ NOTE: It is not necessary to open a new pull request. ❗ More information: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @BjoernLuig . Thanks for your interest in contributing to the Arduino Library Manager.
I see the bot reported a problem with your submission that will block its acceptance:
ERROR: Missing paragraph field in library.properties
See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
(Rule LP034)
ERROR: Missing url field in library.properties
See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
(Rule LP040)
Please fix the problem so we can proceed with your submission.
You will need to do the following things:
- Add the missing fields to the library's
library.propertiesfile. - Bump the value of the
versionfield in the library'slibrary.propertiesmetadata file. - Create a new release or tag in the library repository.
- Add a comment here in the pull request thread that mentions @ArduinoBot.
After that, the automated checks will run again. Once those are passing, your library will be automatically added to Library Manager.
If you have any questions or concerns, please let me know.
Regards, Per
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello again @BjoernLuig. I see you added the missing metadata properties. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.
If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:
https://github.com/sensebox/rg15-arduino-lib/blob/v1.0.1/library.properties
(note that the metadata file did not contain paragraph and url properties at the tagged point in the revision history)
❗ Remember to update the version field in the library's library.properties file as needed before making a release/tag.
Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will be automatically added to Library Manager.
If you have any questions or concerns, please let me know.
Regards, Per
|
@per1234 thanks for helping. |
|
Hello! I'm checking your submission again. |
|
Arduino Lint has suggestions for possible improvements to https://github.com/sensebox/rg15-arduino-lib/: |
|
Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index. The library(s) will be available for installation via Library Manager within a day's time. You can check the logs from the Library Manager indexer for your library(s) here: |
No description provided.