Skip to content

Conversation

internetoftobi
Copy link
Contributor

No description provided.

Copy link
Contributor

A problem was found with your submission https://github.com/MIT-Senseable-City-Lab/octopus-firmware

ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

@github-actions github-actions bot added the topic: submission Add library to the list label Sep 26, 2024
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @internetoftobi
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor Author

@internetoftobi internetoftobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I modified the release.

Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/MIT-Senseable-City-Lab/octopus-firmware:

Linting library in octopus-firmware
INFO: No header file found matching library name (Octopus_Firmware.h). Best practices are for primary header filename to
      match library name.                                                                                               
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name Octopus Firmware contains spaces. Although supported, best practices is to not use     
         spaces.                                                                                                        
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
WARNING: library.properties depends field item(s) Adafruit_DotStar, SparkFun_u-blox_GNSS_Arduino_Library not found in   
         the Library Manager index.                                                                                     
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP048)                                                                                                   
WARNING: No example sketches found. Please provide examples.                                      
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#library-examples
         (Rule LD004)                                                                             

Linter results for project: 0 ERRORS, 3 WARNINGS

-------------------

@github-actions github-actions bot merged commit 392c1fb into arduino:main Sep 26, 2024
9 checks passed
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/MIT-Senseable-City-Lab/octopus-firmware/

github-actions bot pushed a commit that referenced this pull request Sep 26, 2024
@internetoftobi
Copy link
Contributor Author

@ArduinoBot I have corrected the dependency name and updated the release. Please re-run the checks.

@per1234
Copy link
Contributor

per1234 commented Sep 26, 2024

Hello @internetoftobi. The automated system here only operates on open pull requests. Since your submission was already accepted and the pull request merged, the bot won't pay any more attention to this pull request.


We only provide checks for submissions. It is a good idea to perform validation for changes you make to your library, but you'll need to do that yourself as that is not the purpose of the Arduino Library Registry.

You can validate the library by running the Arduino Lint tool on the library on your computer:

https://arduino.github.io/arduino-lint/

Even better, y can set up an automated check in your library repository for compliance with the Library Manager requirements. This could run on every commit and pull request to ensure such violations are caught immediately.

Arduino provides a GitHub Actions action that makes this very easy to do by adding a simple YAML file to the repository:

https://github.com/arduino/arduino-lint-action#readme

This action uses the same Arduino Lint tool as the Library Manager system.

It is in use in all the official Arduino library repositories (example).


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: submission Add library to the list

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants