Skip to content

Conversation

@dralicimen
Copy link
Contributor

This pull request adds the dwiBus library, a communication protocol for Arduino and ESP devices supporting packet fragmentation and CRC-based error handling. The repository URL has been added to repositories.txt. @ArduinoBot

@github-actions github-actions bot added the topic: submission Add library to the list label Oct 28, 2024
@github-actions
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/dralicimen/dwiBus:

Linting library in dwiBus

Linter results for project: no errors or warnings

-------------------

Linting sketch in dwiBus/examples/Client 0x01
ERROR: Prohibited character(s) in file name(s): Client 0x01.ino                                        
       See: https://arduino.github.io/arduino-cli/latest/sketch-specification/#sketch-folders-and-files
       (Rule SS002)                                                                                    

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in dwiBus/examples/Client 0x02
ERROR: Prohibited character(s) in file name(s): Client 0x02.ino                                        
       See: https://arduino.github.io/arduino-cli/latest/sketch-specification/#sketch-folders-and-files
       (Rule SS002)                                                                                    

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in dwiBus/examples/SerialChat/DynamicSerialChat

Linter results for project: no errors or warnings

-------------------

Linting sketch in dwiBus/examples/SerialChat/SimpleSerialChat

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 2 ERRORS, 0 WARNINGS

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @dralicimen
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@dralicimen
Copy link
Contributor Author

@ArduinoBot check this again

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions
Copy link
Contributor

ERROR: Arduino Lint found errors with https://github.com/dralicimen/dwiBus:

Linting library in dwiBus

Linter results for project: no errors or warnings

-------------------

Linting sketch in dwiBus/examples/Client 0x01
ERROR: Prohibited character(s) in file name(s): Client 0x01.ino                                        
       See: https://arduino.github.io/arduino-cli/latest/sketch-specification/#sketch-folders-and-files
       (Rule SS002)                                                                                    

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in dwiBus/examples/Client 0x02
ERROR: Prohibited character(s) in file name(s): Client 0x02.ino                                        
       See: https://arduino.github.io/arduino-cli/latest/sketch-specification/#sketch-folders-and-files
       (Rule SS002)                                                                                    

Linter results for project: 1 ERRORS, 0 WARNINGS

-------------------

Linting sketch in dwiBus/examples/SerialChat/DynamicSerialChat

Linter results for project: no errors or warnings

-------------------

Linting sketch in dwiBus/examples/SerialChat/SimpleSerialChat

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 2 ERRORS, 0 WARNINGS

@github-actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @dralicimen
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello . I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.

If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:

https://github.com/dralicimen/dwiBus/tree/v1.0.0/examples

(note that the example sketches still had the invalid names at the tagged point in the revision history)

❗ Remember to update the version field in the library's library.properties file as needed before making a release/tag.

Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will automatically be added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Oct 28, 2024
@dralicimen
Copy link
Contributor Author

@ArduinoBot

@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@dralicimen
Copy link
Contributor Author

dralicimen commented Oct 28, 2024 via email

@github-actions github-actions bot requested a review from per1234 October 28, 2024 23:59
@github-actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions github-actions bot removed the request for review from per1234 October 29, 2024 00:00
@github-actions github-actions bot removed the status: waiting for information More information must be provided before work can proceed label Oct 29, 2024
@github-actions github-actions bot merged commit ed6aed3 into arduino:main Oct 29, 2024
12 checks passed
@github-actions
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/dralicimen/dwiBus/

github-actions bot pushed a commit that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: submission Add library to the list

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants